Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI configurable list limit on cronworkflow detail page #14065

Open
tczhao opened this issue Jan 9, 2025 · 0 comments
Open

UI configurable list limit on cronworkflow detail page #14065

tczhao opened this issue Jan 9, 2025 · 0 comments
Labels
area/ui good first issue Good for newcomers type/feature Feature request

Comments

@tczhao
Copy link
Member

tczhao commented Jan 9, 2025

Summary

What change needs making?

When visiting cronworkflow detail, e.g. cron-workflows/argo/test-cron-wf
The ui will do a List workflow request to list the historical runs from this cronworkflow.
However, this list limit is hardcoded to 50 instead of configurable like workflows page.

example request
http://localhost:8080/api/v1/workflows/argo?listOptions.labelSelector=workflows.argoproj.io/cron-workflow=test-cron-wf&listOptions.limit=50&fields=metadata,items.metadata.uid,items.metadata.name,items.metadata.namespace,items.metadata.creationTimestamp,items.metadata.labels,items.metadata.annotations,items.status.phase,items.status.message,items.status.finishedAt,items.status.startedAt,items.status.estimatedDuration,items.status.progress,items.spec.suspend

Use Cases

When would you use this?

We want to be able to configure this list limit, either a default list limit or a parameter we can change on the UI.
So that if each workflow is huge, we can use a smaller limit to save the amount of memory needed for server, and not having it OOM,


Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

@tczhao tczhao added type/feature Feature request area/ui good first issue Good for newcomers labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui good first issue Good for newcomers type/feature Feature request
Projects
None yet
Development

No branches or pull requests

1 participant