Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error in Admin Console with latest ClassicPress (1.2) #1

Open
InkyQuill opened this issue Jan 18, 2021 · 6 comments
Open

Fatal Error in Admin Console with latest ClassicPress (1.2) #1

InkyQuill opened this issue Jan 18, 2021 · 6 comments

Comments

@InkyQuill
Copy link

ClassicPress is a fork of Wordpress based on WP 4.9.
Your plugin states it is compatible with WP 4.7+, so it should work, but in practice it shows a fatal error:
Call to undefined function is_avatar_comment_type()

I have found a workaround, mentioned in the following issue: ClassicPress/ClassicPress-v1#92
Opened this to notify you about that issue 'cause it is relevant to your project.

@arielhr1987
Copy link
Owner

Hi @InkyQuill

Looks like I am going to need to update plugin compatibility version to 5.1. As the method you mention was introduced in wordpress 5.1.
Thanks for letting me know about it, I appreciate it.

@timbocode
Copy link

Is is_avatar_comment_type essential to the operation of Letter Avatar? And could you not do something like this:

if wp < 5.0 then do_something()
else is_avatar_comment_type()

The reason I ask is not just because this would maintain compatibility with ClassicPress but also because it would maintain compatibility with WordPress 4.9. Even now, approximately 20% of WP users are still on version 4.9 or less, so that's potentially a sizeable group of users who will no longer be able to use your plugin.

@arielhr1987
Copy link
Owner

I think I can do that.
I will try to release a fully compatible version with wp 4.9

@timbocode
Copy link

Excellent. That would be great.

Thank you. 👍🏻

@arielhr1987
Copy link
Owner

Hi guys
Leira Letter Avatar version 1.3.2 has been release. I tested with WP 4.9 and work very well. Let me know if you experience any other issue.

@nylen
Copy link

nylen commented Feb 15, 2021

Thanks for fixing this.

The plugin page on WordPress.org still says "WordPress Version: 4.7 or higher". You should either update this to say "4.9 or higher" or test with WP 4.7 and confirm that it still works there.

In any case the issue reported with WP 4.9 and therefore ClassicPress looks like it should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants