Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ArquillianResteasyResource to ArquillianRestResource #20

Open
blabno opened this issue Jun 24, 2014 · 7 comments
Open

Rename ArquillianResteasyResource to ArquillianRestResource #20

blabno opened this issue Jun 24, 2014 · 7 comments

Comments

@blabno
Copy link
Member

blabno commented Jun 24, 2014

Initially we had only single impl based on RestEasy but now we've got Jersey and pure JAX-RS implementations, so this annotation may be confusing.

@mojavelinux
Copy link
Member

Please! I think this annotation is turning people off. I first skipped over using the extension because I thought it required Resteasy. Now I see it has JAX-RS 2 client support, but I'm really bothered still by this name.

We could also consider ArquillianRsResource (as in the package name rs). Or is it possible allow ArquillianResource?

@mojavelinux
Copy link
Member

@aslakknutsen Instead of a custom annotation, is is possible to have:

private @ArquillianResource WebTarget target;

Or is the dedicated annotation warranted?

@blabno
Copy link
Member Author

blabno commented Dec 28, 2016 via email

@mojavelinux
Copy link
Member

No problem. I believe that @johnament and @bartoszmajsak have taken over development on this extension.

@hanneskaeufler
Copy link
Contributor

Totally 👍 on this, very confusing!

@bartoszmajsak
Copy link
Member

Gentlemen, I'm no longer in Java world so somebody must take over.

@blabno TRAITOR!

giphy 3

@bartoszmajsak
Copy link
Member

private @ArquillianResource WebTarget target;

@mojavelinux I will check if that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants