Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataset in Dataverse has incorrect contents of tab Terms #100

Open
npoppelier opened this issue Mar 30, 2023 · 4 comments · Fixed by #117 or #121
Open

dataset in Dataverse has incorrect contents of tab Terms #100

npoppelier opened this issue Mar 30, 2023 · 4 comments · Fixed by #117 or #121
Assignees
@Diogenesoftoronto
Labels
invalid This doesn't seem right

Comments

@npoppelier
Copy link
Collaborator

Each dataset in Dataverse has incorrect contents of the tab Terms. The correct contents are available in the prototype developed by the UMCU. There are four sets of legal terms, depending on the dataset type (1, 2, 3a, 3b).
@npoppelier npoppelier added the invalid This doesn't seem right label Mar 30, 2023
@mcantelon
Copy link
Member

Note for fix: reference contents are in dave/terms.py in the prototype repo.

@Diogenesoftoronto Diogenesoftoronto mentioned this issue May 11, 2023
Merged
@joel-simpson joel-simpson reopened this May 12, 2023
@joel-simpson
Copy link
Contributor

This didn't work for me so re-opening until we can confirm it is working as expected.

@Diogenesoftoronto Diogenesoftoronto mentioned this issue May 15, 2023
Merged
@Diogenesoftoronto
Copy link
Contributor

Sorry for taking so long, i thought the datasetversion was the root node for some reason.

@joel-simpson joel-simpson reopened this May 18, 2023
mcantelon added a commit that referenced this issue May 24, 2023
@mcantelon
License metadata upload fix. (#100)
630dfb8
mcantelon added a commit that referenced this issue May 24, 2023
@mcantelon
License metadata upload fix. (#100)
aaab829 
Fixes license metadata upload issue.

pyDataverse's Dataverse metadata schema
(pyDataverse/schemas/json/dataset_upload_default_schema.json in their
Github repository) seems to accept license as a string (as Dataverse's
Native API seems to have previously done in version 4) rather than an
object with "name" and "uri" values.

Made slight change to Dataverse upload job to note this and work around
it.
mcantelon added a commit that referenced this issue May 24, 2023
@mcantelon
License metadata upload fix. (#100)
6cdb6d0 
Fixes license metadata upload issue.

pyDataverse's Dataverse metadata schema
(pyDataverse/schemas/json/dataset_upload_default_schema.json in their
Github repository) seems to accept license as a string (as Dataverse's
Native API seems to have previously done in version 4) rather than an
object with "name" and "uri" values.

Made slight change to Dataverse upload job to note this and work around
it.
mcantelon added a commit that referenced this issue May 24, 2023
@mcantelon
License metadata upload fix. (#100)
fe4cfd3 
Fixes license metadata upload issue.

pyDataverse's Dataverse metadata schema
(pyDataverse/schemas/json/dataset_upload_default_schema.json in their
Github repository) seems to accept license as a string (as Dataverse's
Native API seems to have previously done in version 4) rather than an
object with "name" and "uri" values.

Made slight change to Dataverse upload job to note this and work around
it.
mcantelon added a commit that referenced this issue May 24, 2023
@mcantelon
License metadata upload fix. (#100)
bb0854c 
Fixes license metadata upload issue.

pyDataverse's Dataverse metadata schema
(pyDataverse/schemas/json/dataset_upload_default_schema.json in their
Github repository) seems to accept license as a string (as Dataverse's
Native API seems to have previously done in version 4) rather than an
object with "name" and "uri" values.

Made slight change to Dataverse upload job to note this and work around
it. Also re-enabled pyDataverse metadata schema checking and removed
unneeded line.
mcantelon added a commit that referenced this issue May 25, 2023
@mcantelon
License metadata upload fix. (#100) (#127)
8523340 
Fixes license metadata upload issue.

pyDataverse's Dataverse metadata schema
(pyDataverse/schemas/json/dataset_upload_default_schema.json in their
Github repository) seems to accept license as a string (as Dataverse's
Native API seems to have previously done in version 4) rather than an
object with "name" and "uri" values.

Made slight change to Dataverse upload job to note this and work around
it. Also re-enabled pyDataverse metadata schema checking and removed
unneeded line.
mcantelon added a commit that referenced this issue May 26, 2023
@mcantelon
Fix license metadata issues (#100)
47d5c70
mcantelon added a commit that referenced this issue May 26, 2023
@mcantelon
Fix license metadata issues (#100)
8b885d6 
During creation of Dataverse metadata don't add license metadata to
invalid license types.

During export to Dataverse make sure Dataverse metadata includes
license metadata before trying to modify it.
mcantelon added a commit that referenced this issue May 26, 2023
@mcantelon
Fix license metadata issues (#100)
15a8dac 
During creation of Dataverse metadata don't add license metadata to
invalid license types.

During export to Dataverse make sure Dataverse metadata includes
license metadata before trying to modify it.
mcantelon added a commit that referenced this issue May 26, 2023
@mcantelon
Fix license metadata issues (#100) (#128)
a75a886 
During creation of Dataverse metadata don't add license metadata to
invalid license types.

During export to Dataverse make sure Dataverse metadata includes
license metadata before trying to modify it.
mcantelon added a commit that referenced this issue Jun 13, 2023
@mcantelon
Fix remaining license metadata issues. (#100)
0e7aa3c 
The Dataverse client we were using wasn't handling some of the
license-related metadata fields during dataset creation.
Replace with a raw REST call using the requests module.
mcantelon added a commit that referenced this issue Jun 13, 2023
@mcantelon
Fix remaining license metadata issues. (#100)
b8e3e7b 
The Dataverse client we were using wasn't handling some of the
license-related metadata fields during dataset creation.
Replaced with a raw REST call using the requests module.
mcantelon added a commit that referenced this issue Jun 13, 2023
@mcantelon
Fix remaining license metadata issues. (#100)
96dfc42 
The Dataverse client we were using wasn't handling some of the
license-related metadata fields during dataset creation.
Replaced with a raw REST call using the requests module.
mcantelon added a commit that referenced this issue Jun 13, 2023
@mcantelon
Fix remaining license metadata issues. (#100)
8ef6229 
The Dataverse client we were using wasn't handling some of the
license-related metadata fields during dataset creation.
Replaced with a raw REST call using the "requests" module.
mcantelon added a commit that referenced this issue Jun 13, 2023
@mcantelon
Fix remaining license metadata issues. (#100)
3671996 
The Dataverse client we were using wasn't handling some of the
license-related metadata fields during dataset creation.
Replaced with a raw REST call using the "requests" module.
mcantelon added a commit that referenced this issue Jun 14, 2023
@mcantelon
Fix remaining license metadata issues. (#100) (#130)
4036129 
The Dataverse client we were using wasn't handling some of the
license-related metadata fields during dataset creation.
Replaced with a raw REST call using the "requests" module.
@mcantelon
Copy link
Member

Should be fixed now. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Diogenesoftoronto Diogenesoftoronto

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
4 participants
@mcantelon @joel-simpson @npoppelier @Diogenesoftoronto