Single quote dropped.

[dmolik]

In one of my operator deployments I'm including a metadata field in the envs like so:

        env:
        - name: APP_NAME
          valueFrom:
            fieldRef:
              fieldPath: metadata.labels['app.kubernetes.io/name']
        - name: INSTANCE_NAME
          valueFrom:
            fieldRef:
              fieldPath: metadata.labels['app.kubernetes.io/instance']

when piped through helmify the single quotes are dropped.

[arttor]

Hi, this one will be hard to fix.
Helmify removes all single quotes after marshaling template to yaml. Without this step all yaml values containing helm template expressions (anything with {{}}}) will be quotet and will not work with Helm.

Probabaly, we can change strings.ReplaceAll(spec, "'", "") to more intelligent code, which removes single quotes only aroud yaml value, not inside it.

[dmolik]

hmmmm, I don't want to generate a load of work, what other strategies can we employ that don't generate a complicated and potentially cumbersome feature to support going forward?

ATM the moment I solved this with some post-processing sed.

[arttor]

I think it will be appropriate solution if we find a way to replace current strings.ReplaceAll(spec, "'", "") with a regex. The regex should ignore single quites in the middle of yaml string value.