New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing forwarding for constructor args #24

Open

adcgx opened this issue Aug 20, 2019 · 0 comments

adcgx commented Aug 20, 2019

In areas like:

template <class NodeType, typename... Args>
SomeBuilder<Parent> leaf(Args... args)
{
    auto child = std::make_shared<NodeType>((args)...);
    node->setChild(child);
    return *this;
}

there needs to be forwarding to avoid unintended copying:

template <class NodeType, typename... Args>
SomeBuilder<Parent> leaf(Args&&... args)
{
    auto child = std::make_shared<NodeType>(std::forward<Args>(args)...);
    node->setChild(child);
    return *this;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment