Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

How to notarize built .app for macOS? #61

Open
hellgirl opened this issue Nov 11, 2019 · 6 comments
Open

How to notarize built .app for macOS? #61

hellgirl opened this issue Nov 11, 2019 · 6 comments
Assignees

Comments

@hellgirl
Copy link

According to macOS policy you need to notarize your app, there is a guide here https://medium.com/@TwitterArchiveEraser/notarize-electron-apps-7a5f988406db for electron-builder but is there a way to do it with bundler?

@asticode asticode self-assigned this Nov 19, 2019
@asticode
Copy link
Owner

Unfortunately, this has not been implemented in the bundler.

I'm welcoming PRs though.

@winwisely99
Copy link

I also need this.

Any changes in this area ?

Anyone know if we also need code to sign windows also ?

Is it a golang tool that wraps the OS signing tools that you want ?

@asticode
Copy link
Owner

@winwisely99 it still hasn't been implemented and I'm still welcoming PRs if you feel like contributing.

I think windows also needs signing specially if you're using notifications.

The best would be to integrate the signing steps in the bundler project but as I don't know how signing is done for each OS, maybe it's also a good idea to do it in another project. Also, chances are the electron toolchain already provides a way to sign an astilecron app properly : that would be the first thing I would check.

@winwisely99
Copy link

On Mac we get a .app output from the Bundler
Signing that is straight forward.

On windows I have no idea as I don't have Windows but I presume the output from your bundler is just a standard .exe ?

Does the .App and .Exe require Electron to be somewhere on the computer to run I wonder ?

If that's the case then it's pretty easy to write golang code that calls OS signing tools.

@asticode
Copy link
Owner

The bundler does output an .exe file for Windows.

astilectron apps need electron to be available on the computer but, thanks to the provisioner, they take care of the provisioning themselves.

Again, I'm welcoming PRs :)

@winwisely99
Copy link

Ok will see what I can whip up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants