From 093dac3ea629caf50daef9b989f7aabb44b99270 Mon Sep 17 00:00:00 2001
From: Paul Guyot <pguyot@kallisys.net>
Date: Sun, 29 Oct 2023 16:52:41 +0100
Subject: [PATCH] Fix logic of workflows on push

Tag filter in several workflows meant any tag that doesn't contain a /.
We probably wanted every tag.

And if we have a filter on a tag but no filter on branches, the workflow is
only executed when a tag matches, regardless of path filtering which are always
ignored on tags.

Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
---
 .github/workflows/build-docs.yaml            | 2 ++
 .github/workflows/build-libraries.yaml       | 2 +-
 .github/workflows/build-linux-artifacts.yaml | 2 +-
 .github/workflows/esp32-mkimage.yaml         | 2 --
 .github/workflows/pico-build.yaml            | 2 --
 .github/workflows/publish-docs.yaml          | 4 ++--
 .github/workflows/wasm-build.yaml            | 2 --
 7 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build-docs.yaml b/.github/workflows/build-docs.yaml
index 1b73df3f9..05f425ad2 100644
--- a/.github/workflows/build-docs.yaml
+++ b/.github/workflows/build-docs.yaml
@@ -12,6 +12,8 @@ name: Build Docs
 on:
   # Triggers the workflow on push request and tag events on master branch
   pull_request:
+    tag:
+      - '**'
     branches:
       - 'master'
     paths:
diff --git a/.github/workflows/build-libraries.yaml b/.github/workflows/build-libraries.yaml
index e5775f1a6..78192bd95 100644
--- a/.github/workflows/build-libraries.yaml
+++ b/.github/workflows/build-libraries.yaml
@@ -9,7 +9,7 @@ name: Build Libraries
 on:
   push:
     tags:
-      - '*'
+      - '**'
 
 permissions:
   contents: write
diff --git a/.github/workflows/build-linux-artifacts.yaml b/.github/workflows/build-linux-artifacts.yaml
index 4e3b42cf9..ad6addd00 100644
--- a/.github/workflows/build-linux-artifacts.yaml
+++ b/.github/workflows/build-linux-artifacts.yaml
@@ -9,7 +9,7 @@ name: Build Linux Artifacts
 on:
   push:
     tags:
-      - '*'
+      - '**'
 
 permissions:
   contents: write
diff --git a/.github/workflows/esp32-mkimage.yaml b/.github/workflows/esp32-mkimage.yaml
index a6af84ae1..85e128583 100644
--- a/.github/workflows/esp32-mkimage.yaml
+++ b/.github/workflows/esp32-mkimage.yaml
@@ -15,8 +15,6 @@ on:
       - 'src/platforms/esp32/**'
       - 'src/libAtomVM/**'
       - 'tools/packbeam/**'
-    tags:
-      - '*'
   pull_request:
     paths:
       - '.github/workflows/esp32-mkimage.yaml'
diff --git a/.github/workflows/pico-build.yaml b/.github/workflows/pico-build.yaml
index bcc674817..85be01ac8 100644
--- a/.github/workflows/pico-build.yaml
+++ b/.github/workflows/pico-build.yaml
@@ -14,8 +14,6 @@ on:
       - 'libs/**'
       - 'src/platforms/rp2040/**'
       - 'src/libAtomVM/**'
-    tags:
-      - '*'
   pull_request:
     paths:
       - '.github/workflows/pico-build.yaml'
diff --git a/.github/workflows/publish-docs.yaml b/.github/workflows/publish-docs.yaml
index 7847d7e88..30b9532e9 100644
--- a/.github/workflows/publish-docs.yaml
+++ b/.github/workflows/publish-docs.yaml
@@ -10,10 +10,10 @@ name: Publish Docs
 
 # Controls when the workflow will run
 on:
-  # Triggers the workflow on push request and tag events on master branch
+  # Triggers the workflow on pull request, tag events and pushes on master
   push:
     tags:
-      - '*'
+      - '**'
     branches:
       - 'master'
     paths:
diff --git a/.github/workflows/wasm-build.yaml b/.github/workflows/wasm-build.yaml
index 6abd02509..7a7a29b0c 100644
--- a/.github/workflows/wasm-build.yaml
+++ b/.github/workflows/wasm-build.yaml
@@ -14,8 +14,6 @@ on:
       - 'libs/**'
       - 'src/platforms/emscripten/**'
       - 'src/libAtomVM/**'
-    tags:
-      - '*'
   pull_request:
     paths:
       - '.github/workflows/wasm-build.yaml'