Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving connection overwrites existing custom attributes #22

Open
MrPrashantT opened this issue Apr 27, 2018 · 0 comments
Open

Saving connection overwrites existing custom attributes #22

MrPrashantT opened this issue Apr 27, 2018 · 0 comments

Comments

@MrPrashantT
Copy link

Saving a custom social connection overwrites existing custom attributes (e.g. upstream_params) that were added via API v2.

  1. Create a custom social connection via the extension
  2. Update Connection via API v2, with upstream_params, e.g:

{
  "options": {
   ...//existing attributes
   ...
    "upstream_params": {
      "login_options": {
        "alias": "display"
      }
    }
  }
}
  1. Reload the extension. The GET /connection/{conn_id} contains the new upstream_params in the options.
  2. Click Save without modifying anything. The PATCH call doesn't contain the upstream_params, hence this is lost.

Expected behaviour is for the PATCH call to preserve the existing upstream_params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant