Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a PEP 8 checker to clean up the codebase #69

Open
jlebon opened this issue Sep 1, 2015 · 2 comments
Open

Consider using a PEP 8 checker to clean up the codebase #69

jlebon opened this issue Sep 1, 2015 · 2 comments

Comments

@jlebon
Copy link
Contributor

jlebon commented Sep 1, 2015

As discussed here, it would be nice if we cleaned up the codebase using a PEP8 checker. It remains to be seen which tool we should use (there seem to be many similar checkers available).

Note however, as pointed out in this SO answer, pep8-ifying a whole codebase has some drawbacks. Maybe we should instead enforce a rule that from now on, new commits must be PEP8 compliant.

@miabbott
Copy link
Collaborator

miabbott commented Sep 1, 2015

I'm in favor of enforcing PEP8 compliance for new commits.

I don't think our codebase would suffer too greatly in terms of merge conflicts or breakage of git blame, so I'm also not opposed to PEP8'ing the whole thing.

However, the pep8radius tool looks like it might be a more conservative option.

@aweiteka
Copy link
Owner

aweiteka commented Sep 1, 2015

It would be quite trivial to add a travis CI job to check PEP8 on each PR. We could also have a job to do a dry-run on all steps. Low-hanging fruit. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants