You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed here, it would be nice if we cleaned up the codebase using a PEP8 checker. It remains to be seen which tool we should use (there seem to be manysimilarcheckersavailable).
Note however, as pointed out in this SO answer, pep8-ifying a whole codebase has some drawbacks. Maybe we should instead enforce a rule that from now on, new commits must be PEP8 compliant.
The text was updated successfully, but these errors were encountered:
I'm in favor of enforcing PEP8 compliance for new commits.
I don't think our codebase would suffer too greatly in terms of merge conflicts or breakage of git blame, so I'm also not opposed to PEP8'ing the whole thing.
However, the pep8radius tool looks like it might be a more conservative option.
It would be quite trivial to add a travis CI job to check PEP8 on each PR. We could also have a job to do a dry-run on all steps. Low-hanging fruit. :)
As discussed here, it would be nice if we cleaned up the codebase using a PEP8 checker. It remains to be seen which tool we should use (there seem to be many similar checkers available).
Note however, as pointed out in this SO answer, pep8-ifying a whole codebase has some drawbacks. Maybe we should instead enforce a rule that from now on, new commits must be PEP8 compliant.
The text was updated successfully, but these errors were encountered: