Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists min cmake version required #167

Closed
thomas-roos opened this issue Oct 22, 2024 · 1 comment
Closed

CMakeLists min cmake version required #167

thomas-roos opened this issue Oct 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@thomas-roos
Copy link
Contributor

Describe the bug

CMake version 3.30 complains about missing min cmake version:

|   No cmake_minimum_required command is present.  A line of code such as
ERROR: Task (/codebuild/output/src1843937046/src/actions-runner/_work/meta-aws/meta-aws/meta-aws/recipes-iot/aws-iot-securetunneling-localproxy/aws-iot-securetunneling-localproxy_git.bb:do_configure) failed with exit code '1'
| 
|     cmake_minimum_required(VERSION 3.30)
| 
|   should be added at the top of the file.  The version specified may be lower
|   if you wish to support older CMake versions for this project.  For more
|   information run "cmake --help-policy CMP0000".

I suggest min version 3.22 or older as this is the oldest version on a Yocto lts release.

cmake_minimum_required(VERSION 3.22)
@thomas-roos thomas-roos added the bug Something isn't working label Oct 22, 2024
thomas-roos pushed a commit to aws4embeddedlinux/meta-aws that referenced this issue Oct 22, 2024
thomas-roos pushed a commit to aws4embeddedlinux/meta-aws that referenced this issue Oct 22, 2024
github-actions bot pushed a commit to aws4embeddedlinux/meta-aws that referenced this issue Oct 22, 2024
Added a patch to set min required cmake version:
aws-samples/aws-iot-securetunneling-localproxy#167

(cherry picked from commit 1bc4a67)
thomas-roos pushed a commit to aws4embeddedlinux/meta-aws that referenced this issue Oct 22, 2024
Added a patch to set min required cmake version:
aws-samples/aws-iot-securetunneling-localproxy#167

(cherry picked from commit 1bc4a67)
@ig15
Copy link
Contributor

ig15 commented Oct 22, 2024

Thanks @thomas-roos for raising the ticket.

Closing the ticket since the issue has been fixed in the latest patch update of the Yocto build system:
https://github.com/aws4embeddedlinux/meta-aws/blob/master-next/recipes-iot/aws-iot-securetunneling-localproxy/files/0004-cmake-version.patch

The suggested patch updates maybe integrated into the codebase at a later point of time after consideration of requirements and impact.

@ig15 ig15 closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants