Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on mitchellh/go-homedir. #225

Open
commiterate opened this issue Dec 17, 2024 · 2 comments · May be fixed by #226
Open

Remove dependency on mitchellh/go-homedir. #225

commiterate opened this issue Dec 17, 2024 · 2 comments · May be fixed by #226
Assignees
Labels
bug Something isn't working

Comments

@commiterate
Copy link

commiterate commented Dec 17, 2024

Describe the bug

mitchellh/go-homedir is no longer maintained.

It also introduces an unspecified dependency on sh and getent (code).

Switch to os.UserHomeDir() instead (docs).

Steps to reproduce

N/A

Expected outcome

amazon-ec2-metadata-mock removes the dependency on mitchellh/go-homedir + sh + getent so it's a completely self-contained binary.

Application Logs

N/A

Environment

  • AEMM Version: 1.12.0
  • OS/Arch: Linux
  • Installation method: N/A
@commiterate commiterate added the bug Something isn't working label Dec 17, 2024
@Lu-David Lu-David self-assigned this Dec 17, 2024
@commiterate commiterate changed the title Remove dependency on mitchellh/go-homedir. Remove dependency on mitchellh/go-homedir. Dec 19, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jan 18, 2025
@commiterate
Copy link
Author

Not stale.

@github-actions github-actions bot removed the stale Issues / PRs with no activity label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants