Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor iptable mock #2711

Closed
jchen6585 opened this issue Dec 14, 2023 · 2 comments
Closed

Refactor iptable mock #2711

jchen6585 opened this issue Dec 14, 2023 · 2 comments
Assignees
@jchen6585
Labels
enhancement feature request

Comments

@jchen6585
Copy link
Contributor

jchen6585 commented Dec 14, 2023 •
edited
Loading

What would you like to be added:
Issue to keep track of refactoring iptable mock

Why is this needed:
Currently, our mock has some empty functions and only map the chain to rules that start with -A. We specifically should add chain creation rules to the map as well -N. This leaves some gaps in our test coverage such as testing https://github.com/aws/amazon-vpc-cni-k8s/blob/master/pkg/networkutils/network.go#L379
@jchen6585 jchen6585 self-assigned this Dec 14, 2023
@jchen6585 jchen6585 mentioned this issue Dec 20, 2023
Merged
@jdn5126
Copy link
Contributor

jdn5126 commented Dec 25, 2023

Closing as fixed by #2721

@jdn5126 jdn5126 closed this as completed Dec 25, 2023
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchen6585 jchen6585

Labels
enhancement feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdn5126 @jchen6585