Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy settings not passed through s3-crt #2571

Open
ZacTurnerHPE opened this issue Jul 12, 2023 · 1 comment
Open

Proxy settings not passed through s3-crt #2571

ZacTurnerHPE opened this issue Jul 12, 2023 · 1 comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@ZacTurnerHPE
Copy link

Describe the bug

When setting proxy settings (proxyScheme, proxyHost, proxyPort etc) in Aws::S3Crt::ClientConfiguration and passing these through to a new instance of Aws::S3Crt::S3CrtClient the proxy is used for most operations, but is ignored for operations passed through to crt (get, put).

Expected Behavior

Proxy should be used for all operations

Current Behavior

Proxy is used for the majority of operations, but is not passed through to crt for GET and PUT. For these operations the system proxy (HTTPS_PROXY env) is used instead if set.

Reproduction Steps

Create an instance of Aws::S3Crt::S3CrtClient with proxy set and attempt GET/PUTs

Possible Solution

In S3CrtClient::init other config options are passed through to aws_s3_client_config s3CrtConfig, including tcp and credentials settings, but with no mention of proxy. Hard coding a proxy here seems to make it work for crt operations.

Additional Information/Context

No response

AWS CPP SDK version used

1.11.115

Compiler and Version used

gcc 11.3.1

Operating System and version

Rocky Linux 9

@ZacTurnerHPE ZacTurnerHPE added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2023
@jmklix jmklix self-assigned this Jul 13, 2023
@jmklix jmklix added investigating This issue is being investigated and/or work is in progress to resolve the issue. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 13, 2023
@jmklix
Copy link
Member

jmklix commented Jul 20, 2023

Thanks for creating this issue. I'm glad that you were able to get the proxy working for you by hard coding it. I'm changing this to a feature request as it is not something currently supported by the s3crt client. Please let us know if you are interested in this feature request by 👍 the original issue above.

@jmklix jmklix added feature-request A feature should be added or improved. and removed bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 20, 2023
@jmklix jmklix removed their assignment Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants