Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resumable upload feature #6832

Open
2 tasks
VobileLiuZhiwu opened this issue Jan 20, 2025 · 2 comments
Open
2 tasks

Resumable upload feature #6832

VobileLiuZhiwu opened this issue Jan 20, 2025 · 2 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@VobileLiuZhiwu
Copy link

VobileLiuZhiwu commented Jan 20, 2025

Describe the feature

I would like the lib-storage library to support the resumable upload feature. I went through the source code and found that it can be achieved by simply adding a conditional check. As shown below:

// https://github.com/aws/aws-sdk-js-v3/blob/main/lib/lib-storage/src/Upload.ts#L236
if (this.uploadedParts.find(item => item.PartNumber === dataPart.partNumber)) {
  continue;
}

Can someone help to submit a pull request (PR)? Thank you~

Use Case

I would like the lib-storage library to support the resumable upload feature.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.731.1

Environment details (OS name and version, etc.)

Browser

@VobileLiuZhiwu VobileLiuZhiwu added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. labels Jan 20, 2025
@VobileLiuZhiwu
Copy link
Author

#6833

@VobileLiuZhiwu
Copy link
Author

Otherwise, I could only use bellow ugly workaround to support resuma by using least codes.

Then I wouldn't need to upload the uploaded parts again.

Image

@VobileLiuZhiwu VobileLiuZhiwu changed the title Resumable upload featrue Resumable upload feature Jan 20, 2025
@kuhe kuhe added p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

2 participants