Unhandled 'error' event caused by ChecksumStream

[agaevaslan]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

                const inputData = {
			Bucket: bucketName,
			Key: fileKey,
			Range: _range
		}

		try {
			const getObjectCommand = new GetObjectCommand(inputData)
                         const s3Client = new S3Client({
			    region,
			    credentials,
		         })
			const response = await s3Client.send(getObjectCommand)
                } catch (e) {
                         console.log(e)
                }

when getting a filestream from s3 with GetObjectCommand, if there's a checksum mismatch in @aws-sdk/middleware-flexible-checksums/node_modules/@smithy/util-stream/dist-cjs/checksum/ChecksumStream.js the error is thrown:

`Checksum mismatch: expected "${this.expectedChecksum}" but received "${received}"` +
                    ` in response header "${this.checksumSourceLocation}".`

this error causes from Unhandled 'error' event in ChecksumStream.

It's not catched in catch block around s3Client.send(getObjectCommand) (since it happens after receiving the result after the response stream (response.Body starts producing data) and causes an unhandled exception.
There seems to be no way to catch/handle it (except using global unhandled expection handlers).

Regression Issue

• Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/client-s3 v3.732.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v20.18.1

Reproduction Steps

                const inputData = {
			Bucket: this._config.bucketName,
			Key: fileKey,
			Range: _range
		}

		try {
			const getObjectCommand = new GetObjectCommand(inputData)
                         const s3Client = new S3Client({
			    region,
			    credentials,
		         })
			const response = await s3Client.send(getObjectCommand)
                } catch (e) {
                         console.log(e)
                }

in order to simulate checksum mismatch you can change this.expectedChecksum !== received to this.expectedChecksum === received or smth trueish in @aws-sdk/middleware-flexible-checksums/node_modules/@smithy/util-stream/dist-cjs/checksum/ChecksumStream.js.

Observed Behavior

Checksum mismatch error causes unhandled error event

Expected Behavior

Checksum mismatch error should not cause unhandled error event

Possible Solution

Expose ChecksumStream outside to allow setting error handlers

Additional Information/Context

No response

[zshzbh]

Hey @agaevaslan ,

I can't reproduce this issue.

I'm using "@aws-sdk/client-s3": "3.732",
The code I have

 import {S3Client, GetObjectCommand} from "@aws-sdk/client-s3"
 import {NodeHttpHandler} from "@smithy/node-http-handler"
 const client = new S3Client({
	region : "us-east-1",
	requestHandler: new NodeHttpHandler({
	  connectionTimeout: 5000, // 5 seconds
	  requestTimeout: 5000
	})
  });
  const res = await client.send(new GetObjectCommand({
	Bucket: "new-bucket-maggie-ma",
	Key: "0.txt",
	Range: "bytes=1-"
  }))
  const bodyContents = await res.Body.transformToString();
  console.log('File contents:', bodyContents);
console.log("res", res.$metadata, res.$metadata.response);

The result I got -

➜  OSDS-4611 node index.js
File contents: ello 0!
res {
  httpStatusCode: 206,
  requestId: 'XXXXXXX',
  extendedRequestId: 'cEnsohC2YgBF1XQqgO+Yr68/XXXXX/OxzNF6PZUu7jHoc9BOg=',
  cfId: undefined,
  attempts: 1,
  totalRetryDelay: 0
} undefined

Could you please provide more details with minimal reprod?

[agaevaslan]

hey @zshzbh ,
the issue appears when there is a checksum mismatch.
I don't know how to reproduce a checksum mismatch.

But you can simulate the mismatch by always returning an error in @aws-sdk/middleware-flexible-checksums/node_modules/@smithy/util-stream/dist-cjs/checksum/ChecksumStream.js in

 if (this.expectedChecksum !== received) {
                return callback(new Error(`Checksum mismatch: expected "${this.expectedChecksum}" but received "${received}"` 
                    ` in response header "${this.checksumSourceLocation}".`));
            }

I'm pretty sure this is where the error is generated since it's the only place in the package with such error message.

[kuhe]

We are planning to release a fix for this issue today in a few hours.

[kuhe]

This should be fixed as of https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.735.0 with
https://www.npmjs.com/package/@aws-sdk/client-s3/v/3.735.0.