Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winter Reveler's untextured (white model) #20953

Open
AudioCraZ opened this issue Dec 17, 2024 · 9 comments
Open

Winter Reveler's untextured (white model) #20953

AudioCraZ opened this issue Dec 17, 2024 · 9 comments

Comments

@AudioCraZ
Copy link

Current Behaviour

Winter Revelers in Tanaris and Dustwallow have no textures (white models). May be more, but those are the ones I found.

Expected Blizzlike Behaviour

They should be textured.

Source

No response

Steps to reproduce the problem

  1. multiple clients report issue.

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 2923a4a 2024-12-17 12:28:46 -0300 (master branch) (Win64, RelWithDebInfo, Static)
Connected players: 0. Characters in world: 0.
Connection peak: 1.
Server uptime: 5 hour(s) 23 minute(s) 46 second(s)
Update time diff: 1ms. Last 500 diffs summary:
|- Mean: 2ms
|- Median: 2ms
|- Percentiles (95, 99, max): 5ms, 5ms, 5ms
Using SSL version: OpenSSL 3.4.0 22 Oct 2024 (library: OpenSSL 3.4.0 22 Oct 2024)
Using Boost version: 1.81.0
Using CMake version: 3.31.1
Using MySQL version: 80403
Found MySQL Executable: C:/Program Files/MySQL/MySQL Server 8.4/bin/mysql.exe
Compiled on: Windows 10.0.19045
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in C:/Build/bin/RelWithDebInfo/Data/maps. Total size: 291014951 bytes
vmaps directory located in C:/Build/bin/RelWithDebInfo/Data/vmaps. Total size: 658130721 bytes
mmaps directory located in C:/Build/bin/RelWithDebInfo/Data/mmaps. Total size: 2192910844 bytes
Default DBC locale: enUS.
All available DBC locales: enUS
Using World DB: ACDB 335.13-dev
Latest LoginDatabase update: 2024_12_15_00.sql
Latest CharacterDatabase update: 2024_11_15_00.sql
Latest WorldDatabase update: 2024_12_17_00.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
No modules are enabled

Operating system

Windows 10

Custom changes or Modules

None.

@blinkysc
Copy link
Contributor

Looks like Sepulcher as well

@sudlud
Copy link
Member

sudlud commented Dec 18, 2024

@heyitsbench

@AudioCraZ
Copy link
Author

Looks like the "Winter Revelers" are referencing the wrong model, and that model is showing up all white. Issue found in Theramore as well.

@heyitsbench
Copy link
Contributor

Their model is to be assigned through an aura, afaik most Revelers have one, but apparently not the ones mentioned in this issue.

@stuinabowl
Copy link

The Winter Reveler (GUID 66814) in Hinterlands inside Wildhammer keep is also missing texture/aura.

@YggdrasilWotLK
Copy link
Contributor

This regards 98 revelers as indicated through the following SQL query returning 98 creature GUIDs not having a permanent skin aura addon entry:

SELECT guid
FROM creature
WHERE id1 = 15760 AND guid NOT IN (SELECT guid FROM creature_addon);

A simple approach to skin them all with a 50-50 success/failure rate could be:

INSERT INTO creature_addon (guid, path_id, mount, bytes1, bytes2, emote, visibilityDistanceType, auras)
SELECT
    c.guid,
    0 AS path_id,
    0 AS mount,
    0 AS bytes1,
    1 AS bytes2,
    0 AS emote,
    0 AS visibilityDistanceType,
    FLOOR(26239 + RAND() * (26254 - 26239 + 1)) AS auras
FROM
    creature c
LEFT JOIN
    creature_addon ca ON c.guid = ca.guid
WHERE
    c.id1 = 15760 AND ca.guid IS NULL;

@sudlud
Copy link
Member

sudlud commented Dec 29, 2024

Probably an oversight of mine in #20466 when adding missing spawns of winter revelers

@sudlud
Copy link
Member

sudlud commented Dec 29, 2024

random assignment might probably not be the ideal solution, should assign the correct aura depending on the area that the reveler is located in

26239	Winter Reveler - Human Male
26240	Winter Reveler - Human Female
26241	Winter Reveler - Dwarf Male
26242	Winter Reveler - Dwarf Female
26243	Winter Reveler - Goblin Female
26244	Winter Reveler - Goblin Male
26245	Winter Reveler - Night Elf Female
26246	Winter Reveler - Night Elf Male
26247	Winter Reveler - Orc Female
26248	Winter Reveler - Orc Male
26249	Winter Reveler - Tauren Female
26250	Winter Reveler - Tauren Male
26253	Winter Reveler - Undead Female
26254	.Winter Reveler - Undead Male
39858 Winter Reveler - Draenei Female
39859 Winter Reveler - Draenei Male
39860 Winter Reveler - Blood Elf Female
39861 Winter Reveler - Blood Elf Male
39876 Winter Reveler - Gnome Female
39877 Winter Reveler - Gnome Male

@Vortikai
Copy link

Agreed. It would be off if a human reveler were in Tranquillien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants