[Core] - Leash Longer than before.

[TheSCREWEDSoftware]

Issue linked from CC: chromiecraft/chromiecraft#7636

Triage Notes: Probably Related: #20859

Original Post Below:

---

What client do you play on?

enGB

Faction

Alliance

Content Phase:

1-19

Current Behaviour

Follow range was at least five times longer than usual for this gnoll pack in Elwyn Forest. This pack is located northwest of Stonecairn Lake.

See video:
https://drive.google.com/file/d/1Rlxw6WPi0qtAnFV2RF6scOI-vKEgX5aw/view

Expected Blizzlike Behaviour

Leash range should release about 1/4th-1/5th of the way that they actually followed me.

Source

None.

Steps to reproduce the problem

Follow the same steps I did in video.

1. Aggro gnoll pack in accordande to video linked.
2. Run south. They should release aggro at second line of trees.
3. They continued alot further than those trees and was approximately 4-5 times longer than usual aggro range.

Extra Notes

Video link:
https://drive.google.com/file/d/1Rlxw6WPi0qtAnFV2RF6scOI-vKEgX5aw/view

AC rev. hash/commit

chromiecraft@5f020de

Operating system

Ubuntu 22.04

Modules

• mod-1v1-arena
• mod-ah-bot
• mod-anticheat
• mod-arena-3v3-solo-queue
• mod-arena-replay
• mod-bg-item-reward
• mod-breaking-news-override
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-costumes
• mod-cta-switch
• mod-desertion-warnings
• mod-dmf-switch
• mod-duel-reset
• mod-eluna
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-npc-spectator
• mod-progression-system
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-CarbonCopy
• lua-eventScripts
• lua-ExchangeNpc
• lua-LevelUpReward
• lua-RecruitAFriend
• lua-SendAndBind
• lua-TempAnnouncements
• lua-Zonecheck

Customizations

None

Server

ChromieCraft

[Grimdhex]

I don't remember all cases for leash but here, it doesn't look like an issue where the mobs can attack far enough away? Because here the player looks as hit several time.

[zeonos]

Its easy to test on the Treants (Feral Tender) in the blood elves starting zone.

Even without hitting them once they will follow you until you die and far longer than any retail/classic leach.

They will reset If you do manage to gain enough distance between you and them, like going up a ledge and jumping down.

Once they reset they also "Fly" back to their spawn with a falling animation.

[YggdrasilWotLK]

This doesn't seem like a leashing issue to me, creature leashes extend every time a creature hits a player or gets hit by a player (DOTs exempt afaik). (And quite possibly, the rare elite should not have a leash radius as many elites and rare elites don't, and by extension it keeps the whole pack's leash in check). There's no verifiable reference to the intended range in this report, are retail/classic references available for this pack?

[heyitsbench]

So here's the thing. This pack likely was just hitting the player who made the report as they were running away, which resets the leash currently on AC (it should not, only if the player is practically standing still when hit or when hostile actions are taken against the creature should reset the leash). The issue is due to SetInCombatWith, as when this happens SetInCombatWith is called for both the player and the creature. Removing the leash extension inside SetInCombatWith does resolve this issue, but it breaks leash resets for non-damaging spells (e.g. Curse of Elements spam should reset leashes, removing the extension would cause it not to). This doesn't happen in the vMaNGOS implementation because their leash extension happens in SetInCombatWithAggressor and provides a better frame of reference for who is responsible for the action, but AC has no such method.