Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race conditions when overwriting database file and reading from database at the same time #4

Open
kszymukowicz opened this issue Dec 15, 2020 · 1 comment

Comments

@kszymukowicz
Copy link

hi

tnx for this nice extension.

I have one proposal. To avoid race conditions when database is read and written at the same time maybe it would be good to store database file with some temporary filename and make rename? This way we can greatly lower the risk of race condition.
What do you think ?

@bmack
Copy link
Member

bmack commented Jan 10, 2024

Sorry for the long delay. Yes, we need to download to a temporary file and then move it to the right place. Can you create a patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants