Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameDecoder doesn't handle medium-sized frames properly #97

Open
Crokoking opened this issue Dec 6, 2021 · 1 comment
Open

FrameDecoder doesn't handle medium-sized frames properly #97

Crokoking opened this issue Dec 6, 2021 · 1 comment

Comments

@Crokoking
Copy link

When FrameDecoder determines the size of a medium-sized payload it uses Integer.toUnsignedLong() instead of Short.toUnsignedLong() potentially causing negative payload sizes and essentially breaking the connection.
@epickrram
Copy link
Collaborator

Hi, thanks for the report. We'll look at this when possible.
In the mean time, feel free to submit a PR containing a fix.

@Crokoking Crokoking mentioned this issue Jan 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Crokoking @epickrram