Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colouring compatible with Dark theme #3

Open
ulisse31 opened this issue Sep 23, 2022 · 2 comments
Open

Colouring compatible with Dark theme #3

ulisse31 opened this issue Sep 23, 2022 · 2 comments

Comments

@ulisse31
Copy link

Default colours are sub-optimal when using VSCode dark theme.
Can we have a setting that mass change all colours which show best on Dark settings?

@baincd
Copy link
Owner

baincd commented Sep 25, 2022

Hi @ulisse31,

Default colours are sub-optimal when using VSCode dark theme.

There are separate color settings in the extension for light and dark themes. For the default colors for dark themes, I used Dark+ (the VS Code default dark theme) to find colors I thought worked. But to be honest I do not use a dark theme so I don't have the best perspective.

If you have recommendations for better default colors that would work across a wide variety of dark color schemes, I'd be happy to consider updating the default colors.

Can we have a setting that mass change all colours which show best on Dark settings?

There are already separate color settings for light and dark themes. Can you elaborate on your request?

Thanks!
-Chris

@ulisse31
Copy link
Author

hi @baincd
thanks for the reply.
I think I understand now: I'm using the Dark "high contrast" VS theme, and with this configuration the color coding either doesn't work or the colours are effectively almost invisible.
I'm overwriting the dark settings with the "light" ones and it's definitely a better experience.
I will experiment a little bit and let you know.

Thank you for your nice plugin!
Andrea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants