Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purpose of max_episode_steps in Crafter? #26

Open
jens321 opened this issue Jan 20, 2025 · 0 comments
Open

Purpose of max_episode_steps in Crafter? #26

jens321 opened this issue Jan 20, 2025 · 0 comments

Comments

@jens321
Copy link

jens321 commented Jan 20, 2025

I noticed the Crafter language wrapper specifies a max_steps property, but it seems it's never used: https://github.com/balrog-ai/BALROG/blob/main/balrog/environments/crafter/env.py#L199. In addition, the underlying Crafter environment seems to have its own length property: https://github.com/danijar/crafter/blob/main/crafter/env.py#L29, which is also customizable by BALROG here: https://github.com/balrog-ai/BALROG/blob/main/balrog/config/config.yaml#L67 Hence, I'm wondering if length is the only one needed? And if not, what's the purpose of max_steps?

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jens321