Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calculation of relative change #23

Open
bartveneman opened this issue Mar 24, 2020 · 1 comment
Open

Incorrect calculation of relative change #23

bartveneman opened this issue Mar 24, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bartveneman
Copy link
Owner

bartveneman commented Mar 24, 2020

real world example:

"atrules.imports.totalUnique": {
            "oldValue": 0,
            "newValue": 0,
            "changed": false,
            "diff": {
                "absolute": 0,
                "relative": 1
            }
        },

the relative: 1 can't be right.

@bartveneman bartveneman added bug Something isn't working good first issue Good for newcomers labels Mar 24, 2020
@bartveneman
Copy link
Owner Author

Another example:

"selectors.complexity.unique": {
    "diff": [
      {
        "value": {
          "value": 1,
          "count": 1
        },
        "added": false,
        "removed": true,
        "changed": true
      },
      {
        "value": {
          "value": 1,
          "count": 1
        },
        "added": true,
        "removed": false,
        "changed": true
      }
    ],
    "changed": true
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant