Bazel builds using rules_cc on recent (Ventura, Sonoma) MacOS fail due to -undefined dynamic_lookup

[AIWintermuteAI]

Description of the problem / feature request:

Bazel builds using rules_cc on recent (Ventura, Sonoma) MacOS fail with

compiling lib/findprog-in.c...
./lib/findprog-in.c:137:25: error: implicit declaration of function 'eaccess' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                    if (eaccess (progpathname, X_OK) == 0)
                        ^
./lib/findprog-in.c:137:25: note: did you mean 'access'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/unistd.h:431:6: note: 'access' declared here
int      access(const char *, int);
         ^
./lib/findprog-in.c:211:21: error: implicit declaration of function 'eaccess' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                if (eaccess (progpathname, X_OK) == 0)
                    ^
2 errors generated.

The root cause of this issue was that bazelbuild/bazel#16414 was not merged to rules_cc, but only to rules_llvm and apple_support. Which removed the culprit -undefined dynamic_lookup.

This issue gives more insight in the problem:
bazel-contrib/rules_foreign_cc#859 (comment)

What operating system are you running Bazel on?

What's the output of bazel info release?

release 6.0.0- (@non-git)

If bazel info release returns "development version" or "(@non-git)", tell us how you built Bazel.

Conda forge

What version of rules_cc do you use? Can you paste the workspace rule used to fetch rules_cc? What other relevant dependencies does your project have?

    maybe(
        http_archive,
        name = "rules_cc",
        sha256 = "3d9e271e2876ba42e114c9b9bc51454e379cbf0ec9ef9d40e2ae4cec61a31b40",
        strip_prefix = "rules_cc-0.0.6",
        urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.6/rules_cc-0.0.6.tar.gz"],
    )

What Bazel options do you use to trigger the issue? What C++ toolchain do you use?

Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

[phst]

Probably #163 should be resubmitted; it got rolled back in bc665f9. Right now the toolchain configuration in rules_cc is quite ancient :/

[phst]

Probably already fixed by commit c2549f6

[pzembrod]

Is this indeed now fixed? @keith and @fmeum , do you have insights in this?

[keith]

if not this should be fixed in rules_foreign_cc not here

[pzembrod]

@keith I looked again - if I understand @AIWintermuteAI correctly, this is about -undefined dynamic_lookup still being present in rules_cc, namely in https://github.com/bazelbuild/rules_cc/blob/main/cc/private/toolchain/cc_toolchain_config.bzl#L388. Should we remove that here, in the wake of bazelbuild/bazel#16414?

[keith]

My understanding is that toolchain you linked should be deleted. it was always meant to be in sync with bazel's cc toolchain, but it wasn't kept up to sync. and now that bazel's has moved here in c2549f6, users should use that instead. But yes if we keep it we should remove it (but also would have to change tons more stuff)

[phst]

My understanding is that that file is unused and should be deleted, cf. #287