Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme suggests that rules_cc is not needed yet which will change with Bazel 8 #273

Open
fhanau opened this issue Nov 11, 2024 · 2 comments · May be fixed by #300
Open

Readme suggests that rules_cc is not needed yet which will change with Bazel 8 #273

fhanau opened this issue Nov 11, 2024 · 2 comments · May be fixed by #300
Labels
P3 Accepted issue. Team is likely to fix this issue in the future, but no short-term promises are made.

Comments

@fhanau
Copy link
Contributor

fhanau commented Nov 11, 2024

Description of the problem / feature request:

README.md states that "There is no need to use rules from this repository just yet". This is true for Bazel 7 and below but will change with Bazel 8 where importing rules_cc is required for using CC rules. While Bazel 8 has not been released yet, it is still confusing for developers who want to start trying out Bazel 8 early. This should be updated to state that rules_cc will be needed for Bazel 8.

Feature requests: what underlying problem are you trying to solve with this feature?

Documentation is misleading and suggests to developers that they won't need rules_cc whereas it will be needed when transitioning to the upcoming Bazel 8 release.

keith added a commit to keith/rules_cc that referenced this issue Jan 6, 2025
@keith keith linked a pull request Jan 6, 2025 that will close this issue
@keith
Copy link
Member

keith commented Jan 6, 2025

#300

@pzembrod pzembrod added the P3 Accepted issue. Team is likely to fix this issue in the future, but no short-term promises are made. label Jan 13, 2025
@pzembrod
Copy link
Collaborator

Thanks, @keith !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Accepted issue. Team is likely to fix this issue in the future, but no short-term promises are made.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants