You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our project, we prefer to enable strict protobuf validations, with --fatal_warnings on for our targets.
Currently, we're not able to do so if any of the third-party libraries have protobuf files with warnings. So we're looking for some logic that would allow us to:
Specify --fatal_warnings for our targets
Leave it disabled for third-parties
Proposed Solution
If we take a look into how CC rules are implemented, there are 2 ways to supply CC options:
--copt global flag that sets an option for everybody
copts attribute of cc_library and cc_binary rules
For protoc, there is --protocopt which is sort of similar to --copt, but there is no way to specify options on a per-target basis. It would be great to see protocopts for the proto_library rule.
Something like:
proto_library(
name="sample_proto",
srcs= ["sample.proto"],
protocopts= ["--fatal_warnings"], # Here is the added partvisibility= ["//visibility:public"],
)
The text was updated successfully, but these errors were encountered:
Problem Statement
In our project, we prefer to enable strict protobuf validations, with
--fatal_warnings
on for our targets.Currently, we're not able to do so if any of the third-party libraries have protobuf files with warnings. So we're looking for some logic that would allow us to:
--fatal_warnings
for our targetsProposed Solution
If we take a look into how CC rules are implemented, there are 2 ways to supply CC options:
--copt
global flag that sets an option for everybodycopts
attribute ofcc_library
andcc_binary
rulesFor protoc, there is
--protocopt
which is sort of similar to--copt
, but there is no way to specify options on a per-target basis. It would be great to seeprotocopts
for theproto_library
rule.Something like:
The text was updated successfully, but these errors were encountered: