Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Credo agent shutdown / restart on mobile #2243

Open
cvarjao opened this issue Oct 29, 2024 · 2 comments
Open

Fix Credo agent shutdown / restart on mobile #2243

cvarjao opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cvarjao
Copy link
Member

cvarjao commented Oct 29, 2024

Currently in Credo there is a bug that occurs only in mobile where agent.shutdown() fails before isInitialized is set to false, which prevents us from directly using this Credo API for clean agent shutdown / restart in Bifold. Fixing this in Credo (and making a patch for Bifold / BC Wallet) may improve our websocket disconnect / reconnect process and will simplify the current shutdown / restart code in Bifold / BC Wallet some too.

Relevant issue: openwallet-foundation/credo-ts#2103

AC: nothing got worse and maybe websocket handling got better

@cvarjao cvarjao added this to the epic: performance & stability milestone Oct 29, 2024
@bryce-mcmath
Copy link
Contributor

@jeznorth
Copy link

@bryce-mcmath please updated with AC as discussed.

@bryce-mcmath bryce-mcmath changed the title Resilient connection to mediator Improve Credo agent shutdown / restart Jan 16, 2025
@bryce-mcmath bryce-mcmath added the bug Something isn't working label Jan 16, 2025
@bryce-mcmath bryce-mcmath changed the title Improve Credo agent shutdown / restart Fix Credo agent shutdown / restart on mobile Jan 16, 2025
@bryce-mcmath bryce-mcmath self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants