From a38e7d972db7afef5883effd092d925e249a5eb6 Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Thu, 28 Nov 2024 16:27:59 -0800 Subject: [PATCH 1/5] adding app manual testing steps --- TESTING.md | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 TESTING.md diff --git a/TESTING.md b/TESTING.md new file mode 100644 index 0000000..c68b47d --- /dev/null +++ b/TESTING.md @@ -0,0 +1,116 @@ +# Steps for manual testing of the app + +This document is to guide developers on how to manually test the app. +Steps should be followed in order and be done in a single session from start to finish. + +1. Open app: https://bcgov-env.shinyapps.io/ssdtools/ +2. Be on Data tab + a. Click use boron dataset + i. Ensure preview dataset box populates with data +3. Click on Fit tab + a. Ensure plot and fit table appear without errors + b. Change select column with concentration values from Conc to Chemical + i. It should provide a message saying you need to have your concentration column be a number + ii. Go back to Conc + c. Add burrlll3 distribution + i. Make sure it appears in plot and in table + d. Remove gamma distribution + i. It should be removed from plot and table + e. Change X-axis label to say Conc + i. Label on plot should update + f. Change Y-axis label to say Species + i. Label on plot should update + g. Select unit dropdown, select mg/L + i. Units on Conc should show mg/L in plot + h. Increase text size to 30 + i. Text size on plot should increase + i. Decrease text size to 2 + i. Text should be tiny + j. Test download buttons of plot.png, plot.rds and table.csv + i. Objects should download, check png and csv that they open and look correct + k. Change values in width, height and Dpi boxes + i. Nothing will change as it relates to download things but app should not crash or do anything weird +4. Click on Predict tab + a. Hit the Get CL button + i. Waiting screen should appear and then bring you back to app page with results when it is done calculating + ii. Table should be present under Get CL button + b. Test download buttons of plot.png, plot.rds and table.csv + i. Objects should download, check png and csv that they open and look correct + c. Click on fraction affected radio button + i. Plot should update + d. Increase by concentration to 1.5 + i. Plot should update and put dotted line at 1.5 + e. Change bootstrap samples to 500 + i. Nothing should update other then the text under the Get confidence limit section + f. Change label by to chemical + i. Plot should update with chemical names instead of species + ii. Check through rest of options and ensure they do as expected and no errors occur and out back to Species when done + g. Change to colour by to units + i. Points on plot should change colour and colour label appears on plot + h. Change symbol by to chemical + i. Symbols won't change as only 1 in this data set but symbol label should appear on plot + i. Change colour palette to paired + i. Colours on plot should change colour + j. Change x-axis label to Conc + i. Plot should update with new label name + k. Change y-axis label to Species + i. Plot should update with new label name + l. Add plot title of Title + i. Title should appear at top of plot + m. Change colour legend title Colour + i. Colour legend title should update + n. Change shape legend title to Shape + i. Shape legend title should update + o. Change text size to 4 + i. Text should become really small + p. Change label size to 10 + i. Point labels should become really large + ii. Put back to 3 + q. Change shift label to 5 + i. The labels should shift to the right of the points + ii. Put back to 1.05 + r. Change X-axis minimum to 10 + i. Should see plot shift for starting value on x-axis is 0 + ii. Put back to blank value + s. Change X-axis maximum to 10 + i. Should see the x-axis switch to 10 and cut off a bunch of points + ii. Put back to a blank value + t. Untick Log x-axis + i. Plot should change shape and not be on a log scale anymore + ii. Re-tick box + u. X-axis ticks + i. Remove 100 + 1) Value should disappear + ii. Add 150 + 1) Value should appear + v. Hit download plot.png and confirm plot has the new changes we have made to it in the downloaded file +5. Go to the BCANZ Report tab + a. Fill in toxicant name with "Toxic Frog" + b. Click download Report + i. Select PDF file + 1) Waiting screen will appear + 2) Confirm toxicant is listed in the top of the report + 3) Confirm the formatting and information looks correct + ii. Select HTML file + 1) Waiting screen will appear + 2) Confirm toxicant is listed in the top of the report + 3) Confirm the formatting and information looks correct + iii. Select RMD file + 1) Waiting screen will appear + 2) Confirm toxicant is listed in the top of the report + 3) Confirm the formatting and information looks correct +6. Go to R Code tab + a. Confirm R code is written and looks valid +7. Go to About tab + a. Confirm formatting looks good + b. Check links point to right things +8. Go to About tab + a. Confirm formatting looks good + b. Check links point to right things +9. Click on French button + a. About tab should turn into French + b. Go to the A propos tab + i. It should be in French + c. Click on the English button + i. Should turn back to English + 10. Click on the Help tab \ No newline at end of file From af36bd28dfd87b62831c41ef90dab72bc5d81aff Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Thu, 28 Nov 2024 16:32:18 -0800 Subject: [PATCH 2/5] fledge: Bump version to 0.3.2 --- DESCRIPTION | 2 +- NEWS.md | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 161 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 01bf835..582d317 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: shinyssdtools Title: ssdtools Shiny App -Version: 0.3.1 +Version: 0.3.2 Authors@R: c(person(given = "Seb", family = "Dalgarno", diff --git a/NEWS.md b/NEWS.md index 72ce628..3b9c5b4 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,165 @@ +# shinyssdtools 0.3.2 (2024-11-28) + +- Fix predict plot x-axis bugs (incorrect breaks after transform, incorrect bold face if breaks outside limits, label function breaking if breaks outside limits and converted to NA). + +- Merge pull request #45 from poissonconsulting/ssdtools2. + + Ssdtools2 + +- Merge pull request #41 from poissonconsulting/issue35. + + Issue35 + +- Merge pull request #42 from poissonconsulting/issue31. + + Issue31 + +- Merge pull request #44 from poissonconsulting/issue28. + + add label_comma function and use big.mark for x-axis lables depending on selected language + +- Merge pull request #40 from poissonconsulting/v2ssdtools. + + Updating ssd_fit_dists() to use more default arguments. + +- Merge pull request #27 from poissonconsulting/translation. + + add French translations for new features + +- Merge branch 'bcgov:master' into main. + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/22 (#22). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/4 (#4). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/171 (#171). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/167 (#167). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/170 (#170). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/165 (#165). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/154 (#154). + +- Merge branch 'main' of github.com:poissonconsulting/shinyssdtools. + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/150 (#150). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/132 (#132). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/147 (#147). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/146 (#146). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/135 (#135). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/120 (#120). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/145 (#145). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/100 (#100). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/129 (#129). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/130 (#130). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/136 (#136). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/140 (#140). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/138 (#138). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/125 (#125). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/123 (#123). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/122 (#122). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/121 (#121). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/118 (#118). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/116 (#116). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/108 (#108). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/106 (#106). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/105 (#105). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/104 (#104). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/98 (#98). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/86 (#86). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/85 (#85). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/84 (#84). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/80 (#80). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/79 (#79). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/77 (#77). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/76 (#76). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/75 (#75). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/73 (#73). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/72 (#72). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/69 (#69). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/34 (#34). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/68 (#68). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/67 (#67). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/66 (#66). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/57 (#57). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/56 (#56). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/52 (#52). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/50 (#50). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/49 (#49). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/48 (#48). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/47 (#47). + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/46 (#46). + +- Merge pull request #45 from poissonconsulting/master. + + JOSS paper + +- Merge pull request #44 from EDiLD/patch-1. + + Fix Processing time + +- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/36 (#36). + +- Merge hc changes. + + Merge branch 'master' of github.com:poissonconsulting/ssdca-shiny + + # Conflicts: + # server.R + +- Merge branch 'master' of github.com:poissonconsulting/ssdca-shiny. + + # shinyssdtools 0.3.1 (2024-11-08) - Fix prediction plot x-axis label/breaks bugs From 21496ee858941d292f2ce4062c229a3b41c5a59d Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Thu, 28 Nov 2024 17:20:57 -0800 Subject: [PATCH 3/5] adding testing to build ignore --- .Rbuildignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.Rbuildignore b/.Rbuildignore index b228176..022e1a0 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -21,3 +21,4 @@ ^compliance.yaml$ ^\.github$ ^scripts$ +^TESTING\.md$ From 90ce978fe065bedd332bf7162b1640133762af96 Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Thu, 28 Nov 2024 17:25:43 -0800 Subject: [PATCH 4/5] Fixing R CMD check notes --- DESCRIPTION | 3 --- R/functions-plots.R | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 582d317..db99692 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -32,7 +32,6 @@ Imports: glue, knitr, magrittr, - purrr, readr, rhandsontable, rlang, @@ -50,8 +49,6 @@ Suggests: rsconnect, testthat (>= 3.0.0), ssddata -VignetteBuilder: - knitr Encoding: UTF-8 Language: en-US LazyData: true diff --git a/R/functions-plots.R b/R/functions-plots.R index 35f2c8e..9c8c497 100644 --- a/R/functions-plots.R +++ b/R/functions-plots.R @@ -29,7 +29,7 @@ bold_conc <- function(conc, breaks) { gp_xbreaks <- function(gp){ breaks <- ggplot2::ggplot_build(gp)$layout$panel_params[[1]]$x$breaks - as.numeric(na.omit(breaks)) + as.numeric(stats::na.omit(breaks)) } plot_predictions <- function(x, pred, conc, label, colour, shape, percent, From b121d4353db486348df0d4b2ad3422b39040a2a4 Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Thu, 28 Nov 2024 17:28:40 -0800 Subject: [PATCH 5/5] fix up news --- NEWS.md | 159 +------------------------------------------------------- 1 file changed, 2 insertions(+), 157 deletions(-) diff --git a/NEWS.md b/NEWS.md index 3b9c5b4..3e60bce 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,163 +2,8 @@ # shinyssdtools 0.3.2 (2024-11-28) -- Fix predict plot x-axis bugs (incorrect breaks after transform, incorrect bold face if breaks outside limits, label function breaking if breaks outside limits and converted to NA). - -- Merge pull request #45 from poissonconsulting/ssdtools2. - - Ssdtools2 - -- Merge pull request #41 from poissonconsulting/issue35. - - Issue35 - -- Merge pull request #42 from poissonconsulting/issue31. - - Issue31 - -- Merge pull request #44 from poissonconsulting/issue28. - - add label_comma function and use big.mark for x-axis lables depending on selected language - -- Merge pull request #40 from poissonconsulting/v2ssdtools. - - Updating ssd_fit_dists() to use more default arguments. - -- Merge pull request #27 from poissonconsulting/translation. - - add French translations for new features - -- Merge branch 'bcgov:master' into main. - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/22 (#22). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/4 (#4). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/171 (#171). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/167 (#167). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/170 (#170). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/165 (#165). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/154 (#154). - -- Merge branch 'main' of github.com:poissonconsulting/shinyssdtools. - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/150 (#150). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/132 (#132). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/147 (#147). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/146 (#146). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/135 (#135). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/120 (#120). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/145 (#145). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/100 (#100). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/129 (#129). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/130 (#130). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/136 (#136). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/140 (#140). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/138 (#138). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/125 (#125). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/123 (#123). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/122 (#122). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/121 (#121). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/118 (#118). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/116 (#116). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/108 (#108). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/106 (#106). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/105 (#105). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/104 (#104). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/98 (#98). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/86 (#86). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/85 (#85). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/84 (#84). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/80 (#80). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/79 (#79). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/77 (#77). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/76 (#76). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/75 (#75). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/73 (#73). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/72 (#72). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/69 (#69). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/34 (#34). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/68 (#68). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/67 (#67). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/66 (#66). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/57 (#57). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/56 (#56). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/52 (#52). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/50 (#50). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/49 (#49). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/48 (#48). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/47 (#47). - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/46 (#46). - -- Merge pull request #45 from poissonconsulting/master. - - JOSS paper - -- Merge pull request #44 from EDiLD/patch-1. - - Fix Processing time - -- PLACEHOLDER https://github.com/poissonconsulting/shinyssdtools/pull/36 (#36). - -- Merge hc changes. - - Merge branch 'master' of github.com:poissonconsulting/ssdca-shiny - - # Conflicts: - # server.R - -- Merge branch 'master' of github.com:poissonconsulting/ssdca-shiny. - +- Adding TESTING.md file for steps on how to manually test app. +- Internal changes. # shinyssdtools 0.3.1 (2024-11-08)