Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFRS - Schedule D fuel entry label not showing properly when selected in Schedule B #2338

Open
1 task
justin-lepitzki opened this issue May 26, 2023 · 1 comment
Labels
Bug Something isn't working Low Low priority Main release For immediate release into production when ready

Comments

@justin-lepitzki
Copy link
Collaborator

justin-lepitzki commented May 26, 2023

Describe the Bug
When selecting a Schedule D fuel entry from within Schedule B, after selection, the label switches to a number rather than showing the correct Schedule fuel entry label (e.g., "Renewable Diesel 7.01"). Format is already built into the labeling of the fuel entry tabs in Schedule D: Fuel Type & Carbon Intensity.

Expected Behaviour
When selecting a Schedule D fuel entry from the dropdown list within Schedule B, I expect the label to be maintained after selection.

Actual Behaviour
The label changes to a number that appears to based on how many fuel entries have been created in Schedule D (e.g., second fuel entry shows a label of "2")

Implications
This unexpected behaviour makes it difficult to track the reporting of fuel using Schedule D entries. In some cases a supplier may have 8+ Schedule D entries and labeling them by number created (i.e., 1-8) is not meaningful.

Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: BCeID user / Compliance Reporting role

  1. Go to a Compliance Report in a Draft state
  2. Create a new fuel entry within Schedule D and fill out the required information
  3. Navigate to Schedule B and create a new line to report the fuel created in Schedule D.
  4. Select the fuel type to be the same as the one you selected when creating the Schedule D entry, same with the fuel class.
  5. Select the "GHGenius modelled" option for the "Provision of the Act Relied Upon to Determine Carbon Intensity" column
  6. Select the Schedule D fuel entry from the dropdown list in the "Fuel Code or Schedule D Entry" column
  7. See error

Development Checklist:

  • Go to ScheduleBContainer and fix the logic to set value equal to what user selected. It looks like its being set to total number of schedule D entry

Screenshots:
Screenshot 2023-05-26 1.png

@justin-lepitzki justin-lepitzki added Bug Something isn't working Low Low priority labels May 26, 2023
@kcabhar
Copy link
Contributor

kcabhar commented May 26, 2023

@justin-lepitzki justin-lepitzki added the Main release For immediate release into production when ready label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Low Low priority Main release For immediate release into production when ready
Projects
None yet
Development

No branches or pull requests

2 participants