Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification and Updates Required for Version Specifications and Python Compatibility in Dockerfile and pyproject.toml #59

Open
flowers0 opened this issue Dec 21, 2024 · 0 comments

Comments

@flowers0
Copy link

Dear Maintainers,

I have encountered the following issues while working with this project, and I would greatly appreciate your assistance in resolving them:

### 1. Missing Version Specification for Cloned Repositories
In the Dockerfile, several repositories are cloned without specifying a version or commit hash. Given that some of these repositories have been updated multiple times, it is crucial to lock the versions to ensure reproducibility and avoid potential compatibility issues. Below are the repositories that need version specification:

bash

RUN pip install git+https://github.com/naokiyokoyama/frontier_exploration.git
git+https://github.com/ChaoningZhang/MobileSAM.git
git+https://github.com/naokiyokoyama/depth_camera_filtering
git+https://github.com/facebookresearch/habitat-sim.git@v0.2.4
git+https://github.com/naokiyokoyama/bd_spot_wrapper.git
git+https://github.com/IDEA-Research/GroundingDINO.git

While the habitat-sim repository specifies a version (v0.2.4), the others do not. Could you please specify versions or commit hashes for these repositories to ensure stability and reproducibility?

### 2. Python Version Conflict Between Dockerfile and pyproject.toml
The Dockerfile specifies Ubuntu 22.04 and Python 3.10:

bash

FROM ubuntu:22.04
RUN apt-get install python3.10 ...

However, the pyproject.toml specifies a Python version requirement of >=3.9, and certain packages like numpy==1.26.4 are not compatible with Python 3.10. Since Ubuntu 22.04 primarily supports Python 3.10 and does not natively support Python 3.9, this creates a compatibility conflict.

Could you please clarify the following:

  1. Should the project target Python 3.9 or Python 3.10?

  2. If Python 3.9 is required, could you update the Dockerfile to install Python 3.9 explicitly or provide a new Dockerfile with updated requirements?

  3. Alternatively, if Python 3.10 is preferred, could you ensure all dependencies in pyproject.toml are compatible with Python 3.10?

Thank you for your attention to these matters. I look forward to your response and any updates to the project files to address these issues.

Thank you for your attention to these matters. I look forward to your response and any updates to the project files to address these issues.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant