Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Reuqest] Adding Add-on settings where the view options are. #1081

Open
Goldenfreddy0703 opened this issue May 5, 2024 · 1 comment

Comments

@Goldenfreddy0703
Copy link

Hey there! I hope you're doing well. I wanted to take a moment to express my gratitude for creating such an exceptional skin. It's been a joy to use – modern, intuitive, and downright stylish and very fast thanks to the home menu styles.. Thank you for your hard work and dedication to making something truly remarkable.

I do have a small feature request if you don't mind. I've noticed that accessing addon settings can sometimes be a bit cumbersome, especially when deep within an addon. I was wondering if it might be possible to incorporate addon settings into the view options, in Kodi's Estuary skin, they do have addon settings in there view options.. This would greatly enhance user experience by providing easier access to addon settings without interrupting the flow. If you guys don't mind adding that, that would be fantastic if you guys could.
Thank you very much.

This is what Estuary has done with their where they have view options and actions:
image

If we could add Addon Settings in this part of the skin, that would be amazing:
image

@Goldenfreddy0703
Copy link
Author

Hey so im not the best at coding but i looked into the skin and manage to figure out how to code addon setting into your view options menus in MyVideoNav.xml and MyMusicNav.xml. Here is the code and a screenshot of what i did. For Strings, I can add the string translations if you like me to as well as a pr.
Thank you

Code:
MyVideoNav.xml - Replaced Lines 757 - 764
MyMusicNav.xml - Replaced Lines 243 - 250

                <control type="button" id="55555">
                    <include>DefContextMenuLabel</include>
                    <label>Actions</label>
                </control>
                <control type="button" id="9089" description="Add-on settings">
                    <include>DefContextButtonGradient</include>
                    <align>left</align>
                    <label>Add-on settings</label>
                    <onclick>SetFocus(50)</onclick>
                    <onclick>Addon.OpenSettings($INFO[Container.PluginName])</onclick>
                </control>
                <include>ButtonPlaylist</include>
                <control type="button" id="5556">
                    <include>DefContextButtonGradient</include>
                    <align>left</align>
                    <label>31195</label>
                    <onclick>ReloadSkin()</onclick>
                    <visible>Skin.HasSetting(DebugInfo)</visible>
                </control>

Screenshot:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant