Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Thank you! #4

Open
klaussa opened this issue May 17, 2020 · 2 comments
Open

Thank you! #4

klaussa opened this issue May 17, 2020 · 2 comments

Comments

@klaussa
Copy link

klaussa commented May 17, 2020

Dear @beepsoft ,

Thank you for the detailed experiment. 2 questions:
What are the biggest pitfalls to pursue integrating react components in grapesjs - in the sense of further development?
What comes into your mind if webcomponnets would be instead of react components?

Kind Regards

@beepsoft
Copy link
Owner

Well, I have not really worked with grapsejs since I created this POC implementation, so I don't really know what problems one may face when using react components + grapsejs together in the wild. But I will come back to this some day and will investigate more, because I will eventually need this in one of my projects.

However my solution seems a bit bloated with my own HTML parser implementation compared to @emilsedgh's solution, which is more elegant, although this codesandbox unfortunately doesn't work anymore:

https://codesandbox.io/s/immutable-river-f43bt

I also haven't worked with webcomponnets yet, so I don't know what problems one may find when using those with grapsejs.

@emilsedgh
Copy link

Hey guys. I don't know why the code sandbox is broken. Unfortunately I don't have the time to look into that right now.
I think, and I hope, within the next year I'll have the chance to get back to this project and come up with a properly maintained and released version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants