Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from using project options #101

Open
wusatosi opened this issue Dec 3, 2024 · 4 comments
Open

Move away from using project options #101

wusatosi opened this issue Dec 3, 2024 · 4 comments

Comments

@wusatosi
Copy link
Member

wusatosi commented Dec 3, 2024

In weekly sync of 12-02.
We decide to discourage use of third-party CMake build dependency, specifically project_options.
We probably need to move away from this in execution26.

This is low priority.

@ClausKlein
Copy link
Collaborator

The arguments are weak.

You have no concept and no knowledge to create this cmake infrastructure yourself.
FetchContent is used in other projects to get GMock, so offline build is no really a good argument against project_options.

Finally, you have no usable presets and no real ideas how to export cmake config packages in a usable way.

Bad Luck

@wusatosi
Copy link
Member Author

wusatosi commented Dec 3, 2024

The arguments are weak.

You have no concept and no knowledge to create this cmake infrastructure yourself. FetchContent is used in other projects to get GMock, so offline build is no really a good argument against project_options.

Finally, you have no usable presets and no real ideas how to export cmake config packages in a usable way.

Bad Luck

Hey, I pitched this to the meeting on a neutral stance.
I didn't make any arguments against this.
I am simply flagging this here and noting the consensus.

@ClausKlein
Copy link
Collaborator

@wusatosi sorry, I was meaning the beman project, not you personally !

@dietmarkuehl
Copy link
Collaborator

dietmarkuehl commented Dec 3, 2024

I don't think we had an exhaustive discussion that on Monday. I think we should assess what we want to achieve and what is an effective way to achieve things. Removing useful support without a strong reason seem premature. I don't think this repo is actually the place to discuss that, though: I imagine this discussion to be held on exemplar and other repos following suit eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants