Date for balance statement could be wrong

[rapiz1]

We assume transactions are sorted and find the first date by using the date from the first transaction

monopoly/src/monopoly/statements/credit_statement.py

Lines 20 to 29 in b069f1e

	def post_process_transactions(self, transactions) -> list[Transaction]:
	previous_month_balances = self.get_prev_month_balances()
	if previous_month_balances:
	first_transaction_date = next(iter(transactions)).date
	for prev_month_balance in previous_month_balances:
	groupdict = TransactionGroupDict(**prev_month_balance.groupdict())
	groupdict.transaction_date = first_transaction_date
	prev_month_transaction = Transaction(**groupdict)
	transactions.insert(0, prev_month_transaction)
	return transactions

But it's not always sorted by date in the raw statement. For example, UOB puts CRedit before debit. So the previous balance statement can have a wrong date. What's worse is that at this point we haven't parsed the date yet so we can't sort.

I have a patch to solve it but it unfortunately requires a bigger change and move the post processing of previous balance statement into Pipeline.transform

[benjamin-awd]

We assume transactions are sorted and find the first date by using the date from the first transaction

Yes unfortunately monopoly currently has a very inelegant way of finding the statement date 😢

Do you have an example of how the UOB statement would fail? I think the UOB credit/debit statements I used don't have this particular ordering issue.

I have a patch to solve it but it unfortunately requires a bigger change and move the post processing of previous balance statement into Pipeline.transform

This is fine by me. It probably makes more sense for post-processing to happen in the transformation layer anyway