Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend functionality of add_id_to_local_song_if_available_in_ct() #13

Open
bensteUEM opened this issue Jan 25, 2023 · 2 comments
Open

Extend functionality of add_id_to_local_song_if_available_in_ct() #13

bensteUEM opened this issue Jan 25, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone
1.0.x

Comments

@bensteUEM
Copy link
Owner

Primary Match CCLI ID if exists

Secondary Match songbook/title/author

only third option should be matching songbook/title without author (as implemented at the moment ...)
bensteUEM added a commit that referenced this issue Jan 25, 2023
@bensteUEM
fixing #12 with cleanup of song IDs from CT, followup in #13
ee48ec9
@bensteUEM
Copy link
Owner Author

and add test_add_id_to_local_song_if_available_in_ct

bensteUEM added a commit that referenced this issue Jan 30, 2023
@bensteUEM
SongBeamerQS #7 and #6 Download SNG if local file does not exist
2367811 
moved api out of read_baiersbronn_ct_songs to generalize and refactored to get_ct_songs_as_df
and stubs for tests related to #13 #14 #15
@bensteUEM bensteUEM added the enhancement New feature or request label Feb 17, 2024
@bensteUEM bensteUEM added this to the 1.0.0 milestone Feb 17, 2024
bensteUEM added a commit that referenced this issue Mar 7, 2024
@bensteUEM
fix #27; link and define #13,#14,#29,#30,#32,#33,#34,#35,#36
1bc28c5
@bensteUEM bensteUEM modified the milestones: 1.0.0, 0.9.1 May 6, 2024
@bensteUEM bensteUEM changed the title Exten functionality of add_id_to_local_song_if_available_in_ct() Extend functionality of add_id_to_local_song_if_available_in_ct() May 6, 2024
bensteUEM added a commit that referenced this issue May 6, 2024
@bensteUEM
implement test_add_id_to_local_song_if_available_in_ct #13
ef9ea09
@bensteUEM
Copy link
Owner Author

test case implemented as part of 0.9.1 but extended compare functionality is a new feature

@bensteUEM bensteUEM modified the milestones: 0.9.1, 1.0.0 May 6, 2024
bensteUEM added a commit that referenced this issue May 7, 2024
@bensteUEM
fix #27; link and define #13,#14,#29,#30,#32,#33,#34,#35,#36
780b622
bensteUEM added a commit that referenced this issue May 7, 2024
@bensteUEM
implement test_add_id_to_local_song_if_available_in_ct #13
e3e59c4
@bensteUEM bensteUEM modified the milestones: 1.0.0, 1.0.x May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.x
Development

No branches or pull requests
1 participant
@bensteUEM