Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does rtrdump actually downgrade the version? #122

Closed
partim opened this issue Apr 5, 2024 · 3 comments
Closed

Does rtrdump actually downgrade the version? #122

partim opened this issue Apr 5, 2024 · 3 comments

Comments

@partim
Copy link

partim commented Apr 5, 2024

We’re having an issue in Routinator (NLnetLabs/routinator#950) where rtrdump fails to produce any output when not started with -rtr.version 1. It does print “Downgrading to version 1” but then seems to just close the connection. I did test with the fixed RTR server code that reports the expected version in the error PDU.

Can you confirm that this indeed because rtrdump doesn’t retry with the new version or is there something that Routinator does wrong?

@ties
Copy link
Collaborator

ties commented Apr 5, 2024

You can check what is sent with Wireshark.

I also hit this when using stayrtr as a library: there is a message but no actual version downgrade. I assumed this was an error in my usage.

@partim
Copy link
Author

partim commented Apr 5, 2024

I checked with Wireshark – it just closes the connection after receiving the error. I’m asking because there were issues around this earlier and want to double check whether there are more fixes that are needed on my side.

@job
Copy link
Member

job commented Aug 7, 2024

Yes, rtrdump (at least on the master branch) downgrades:

$ ./dist/rtrdump-v0.5.1-62-g9416292-linux-x86_64
INFO[0000] Connecting with plain to 127.0.0.1:8282
INFO[0000] Downgrading to version 1
$ jq -c '.metadata' output.json
{"vrps":599727,"aspas":0,"bgpsec_pubkeys":0}

@job job closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants