Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify react-chart-editor #352

Open
mauromiguelm opened this issue May 2, 2023 · 2 comments
Open

Simplify react-chart-editor #352

mauromiguelm opened this issue May 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@mauromiguelm
Copy link
Contributor

mauromiguelm commented May 2, 2023

We received some feedback that the plot editor is overly complicated. We could remove a few functionalities, and focus on what users really need. Maybe a tutorial on how to use the editor would also make sense.

Summary of challenges:

  1. Identify what functionalities users need and are not available, e.g. color plotted points by phenotype (covariate)
  2. Reduce complexity of the editor
  3. Tutorial on how to use the editor

Axel:

While the ability to edit some figures is welcome, I find the editing menus non-intuitive and also hard to navigate. I could change the colours of texts and axes, but not of the actual sample dots in a tSNE map under dataview, for example. SO while it looks potentially cool, it is actually a pretty useless feature if I cannot change the most important aspect of a plot.

Also, the only plots customers repeatedly asked to be customisable (volcano and MA plots in pairwise DEG) are not editable. I realise that the editor may work on an individual gene (dot) basis, but customers have been asking to, say, colour significantly upregulated genes in red and significantly downregulated ones in blue. That may require a different approach than the plotly editor currently implemented.

@mauromiguelm mauromiguelm added the enhancement New feature or request label May 2, 2023
@mauromiguelm
Copy link
Contributor Author

from talk with Carson:

  • Identify features that are relevant for users
  • Protorype could be done with hidding html elements, but do not advice putting that in to production
  • We could pass a grid, that would allow users to color plots by their phenotypes. But that is compliated and should be done directly in the app.

@ncullen93
Copy link
Contributor

ncullen93 commented Jun 24, 2023

I took a look at the editor and can clearly identify parts that should be removed:

  • The entire "Structure" menu. This functionality is not very relevant for us... users should never need to alter the structure of the plot (e.g., change a bar plot to a scatter plot). Anyone advanced enough to do that would just download the plot data and make their own plots.
  • The "Traces" submenu within the "Style" menu. This functionality is difficult to understand and does not seem to add much.

Removing those two things greatly simplifies the editor. Then the result will be two submenus (Style and Annotate) with three submenus each. In the style menu, users can change the colors, axis labels, title, etc. In the annotate menu, users can draw lines and add extra text. These are the two main things people want to do.

@mauromiguelm mauromiguelm added the high priority high priority issues label Aug 8, 2023
@mauromiguelm mauromiguelm removed their assignment Jul 10, 2024
@ivokwee ivokwee removed the high priority high priority issues label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants