Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate sample source and material name columns #35

Open
mkuhring opened this issue Feb 25, 2019 · 1 comment
Open

Validate sample source and material name columns #35

mkuhring opened this issue Feb 25, 2019 · 1 comment
Milestone

Comments

@mkuhring
Copy link
Contributor

Warnings on

  • Overlap of source and sample names
  • Reuse of the same material name in different columns, even in different assays

Errors on

  • Study sample names not a superset of assay sample names
@mkuhring
Copy link
Contributor Author

This is more complex than I expected and would need some major restructuring. Therefore, I suggest postponing it for now.

Reuse of the same material name in different columns

Once we parsed we don't have any column information left, just the graph. We would need to recreate a table just for this validation or rely on the material name type (should be possible now that we going to use Library Name instead of a second Extract Name).

even in different assays

Currently we don't have any "parenting" structure, i.e. the context (joint usage) of investigation, studies and assays is currently provided by the API user. This might be something we want to change in general.

Study sample names not a superset of assay sample names

Same here.

@mkuhring mkuhring added this to the v0.3 milestone Jun 6, 2019
@holtgrewe holtgrewe modified the milestones: v0.3.0, v0.4.0 Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants