Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide Toolbar navIcon #19

Open
mrcasals opened this issue Dec 4, 2015 · 1 comment
Open

Add ability to hide Toolbar navIcon #19

mrcasals opened this issue Dec 4, 2015 · 1 comment

Comments

@mrcasals
Copy link
Contributor

mrcasals commented Dec 4, 2015

PR #14 added the ability to overwrite the default Toolbar navIconName. I want to use a Toolbar without any navIcon, so I was thinking that the default behaviour could be no icon, and if the user wanted an icon then they would need to explicitly name it:

Toolbar without an icon:

        <Toolbar
          actions={this.props.actions}
          primary="paperLightBlue"
          title={this.props.title}
        />

Toolbar with an icon:

        <Toolbar
          navIconName="menu"
          actions={this.props.actions}
          primary="paperLightBlue"
          title={this.props.title}
        />

What do you think?

@binggg
Copy link
Owner

binggg commented Dec 4, 2015

Yes, You are right. It was my original intention. I forget it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants