Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqrepo cli not installed in 0.6.6 and 0.6.7 #138

Closed
reece opened this issue Feb 19, 2024 · 4 comments · Fixed by #139
Closed

seqrepo cli not installed in 0.6.6 and 0.6.7 #138

reece opened this issue Feb 19, 2024 · 4 comments · Fixed by #139
Labels
bug Something isn't working

Comments

@reece
Copy link
Member

reece commented Feb 19, 2024

Describe the bug

Some change between 0.6.5 and 0.6.6 causes the seqrepo command line script to not be installed. This issue affects local (dev) installation and the pypi packages. 0.6.7 has the same issue.

To Reproduce
Steps to reproduce the behavior:

  1. Create a venv
  2. pip uninstall biocommons.seqrepo, pip install biocommons.seqrepo==0.6.7, then seqrepo. You should see seqrepo: command not found.
  3. Try again with 0.6.6. Same outcome.
  4. Try again with 0.6.5. seqrepo should start and show the help message.
  5. The same occurs in a development environment with something like git checkout 0.6.7; pip uninstall biocommons.seqrepo; pip install -e .[dev].

Expected behavior

The seqrepo command line tool should be installed in all versions.

@korikuzma @jsstevenson @andreasprlic

@reece reece added the bug Something isn't working label Feb 19, 2024
@reece
Copy link
Member Author

reece commented Feb 19, 2024

I have been unable to isolate the underlying cause, but switching from setup.cfg to pyproject.toml seems likely.

Note that biocommons.example works as expected.

@jsstevenson
Copy link
Contributor

Just on my phone between baby naps, but the blame definitely points my way. Maybe setuptools is unhappy when entry_points is still defined in setup.py/cfg but other parts of the build specs have been moved to pyproject.toml? Either way, an overwrite of my last PR with the stuff in the example template is overdue, so if that also fixes this issue, then that's two birds at once

@reece
Copy link
Member Author

reece commented Feb 19, 2024

Found it. The error was my merge at ee80d92. I'll fix.

@korikuzma
Copy link

@larrybabb I think this is the issue you were encountering today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants