Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Q-squared values for standalone Songbird? #113

Open
fedarko opened this issue Feb 7, 2020 · 3 comments
Open

Getting Q-squared values for standalone Songbird? #113

fedarko opened this issue Feb 7, 2020 · 3 comments
Labels
enhancement New feature or request ui Improving the user interface

Comments

@fedarko
Copy link
Collaborator

fedarko commented Feb 7, 2020

As far as I'm aware, these values are only computed using the summarize-paired QIIME 2 visualizer. It'd be ideal to support this for standalone Songbird, if possible (from going over the README it doesn't seem like the HPARAMS stuff is a perfect substitute).

@fedarko fedarko added enhancement New feature or request ui Improving the user interface labels Feb 7, 2020
@gibsramen
Copy link
Contributor

On my recent forum post about a related issue it was suggested that an intermediate artifact/structure might be broadly useful for things like this involving the null/baseline model comparisons.

@fedarko
Copy link
Collaborator Author

fedarko commented Feb 7, 2020

Ah shoot I completely forgot about that post! Yes, if we can output that then that'd be perfect -- I know the QIIME 2 summarize-paired visualizer can take in SampleData[SongbirdStats] artifacts and produce a Q-squared value, and we could theoretically spin that code off into its own module within Songbird that takes in two TSV files and outputs a file / QZA containing the Q-squared value.

I think the hardest part here might be figuring out how to extract the SampleData[SongbirdStats] stuff from a standalone run of Songbird, then... or maybe it'd be easier to add an option to standalone Songbird that saves these stats to an analogous filetype to the SampleData[SongbirdStats] artifacts, say run-stats.tsv or whatever, and then add a simple script that just computes the Q-squared value from two of those TSV files. Whatever would be easy to develop and not too terrible for end users is ok with me :)

@mortonjt
Copy link
Collaborator

mortonjt commented Feb 7, 2020

Note that we do save checkpoints of the model in the standalone version, so all of those stats can be retrieved by directly utilizing the built model.

But I don't think it is a good idea to add in major changes until we switch everything over to pytorch.

fedarko added a commit to fedarko/songbird that referenced this issue Feb 7, 2020
- mentioning lack of parity between versions right now (biocore#113)
- clarifying that Q^2 should be at least 0 (linked to q2 forum post)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Improving the user interface
Projects
None yet
Development

No branches or pull requests

3 participants