Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Discretize and Continuize #6984

Open
ajdapretnar opened this issue Jan 15, 2025 · 3 comments
Open

Unify Discretize and Continuize #6984

ajdapretnar opened this issue Jan 15, 2025 · 3 comments
Assignees

Comments

@ajdapretnar
Copy link
Contributor

Discretize and Continuize have different wording for default. Judging by the outdated documentation, Continuize used to say "Default setting: leave". Discretize has "Default setting: keep", which is already inconsistent. However, Continuize now has "Preset: no change". It would be nice to have this streamlined.

Screenshot 2025-01-15 at 13 10 16 Screenshot 2025-01-15 at 13 10 19
@janezd janezd self-assigned this Jan 17, 2025
@janezd
Copy link
Contributor

janezd commented Jan 19, 2025

  • Discretize show "Keep categorical" and Continuize shows "Keep numeric". This is already OK.
  • There is a small inconsistency in the short forms -- "Keep as is" (Discretize) vs. "Keep" (Continuize). We can fix this.
  • "No change" is different. The former two are about changing the variable type while this one is about scaling. It would keep this "No change" as it is, without changes. :)

@ajdapretnar
Copy link
Contributor Author

This is not what I had in mind. I was referring to the below part. Discretize says "Default setting: keep", while Continuize says "Preset: no change". I would prefer having the same phrase in both, which ever one we choose.

Image Image

@janezd
Copy link
Contributor

janezd commented Jan 20, 2025

Ah, I, see. Also note that individual variables without specific setting in Discretize are marked by (default), while in Continuize they are not.

  • I (it was probably me) probably used different two different words because I liked neither. :) "Default setting" sounds too much like a widget default, and "Preset" is ... something I probably invented to avoid "Default". I think I prefer "Default", but if we can think of something better...
  • As for (default) in the list view, I think I like it so I'd add it to Continuize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants