-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📎 HTML: Implement "Attribute Position" option #4828
Comments
@dyc3 May I take this issue? |
@dyc3 should we implement this against the |
This should be applied to |
Hey @Geun-Oh, any updates? |
@dyc3 Hello, I'm sorry about the late notice. Since I'm not good at rust that much than i thought (even though i selected a good-first-issue,,) and I'm also struggling hard on my job these days, it takes long time that i thought. So, you can unassign me if you wanna assign other person. Thanks for waiting. |
No worries! I'll unassign you for now. |
For whoever wants to contribute, the implementation of this option isn't complicated, because we already have this logic in the JSX formatting. Here's how it works in the JSX formatter biome/crates/biome_js_formatter/src/jsx/lists/attribute_list.rs Lines 12 to 22 in 0bb86c7
|
@dyc3 Can I take this again? I think I can do this during holiday week. |
Description
The attribute position option has 2 values:
auto
andmultiline
.auto
is the current behavior, and the default behavior. This task is to implement themultiline
side of this option.Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide.
The text was updated successfully, but these errors were encountered: