Still need to be brought back for 1.0

[thunderbiscuit]

This issue compiles a list of structs and methods that were commented out in the move to the 1.0 early releases in order to keep track of what we probably want to bring back, without having to keep them as comments in the codebase.

• TxIn type
• Payload type (doesn't exist anymore)
• Address.from_script() method
• Address.payload() method
• Transaction.lock_time()
• Transaction.input()
• Transaction.output()
• Psbt.txid() (not there anymore)
• Psbt.combine()
• Psbt.fee_amount() (renamed to fee())
• Psbt.fee_rate() (not there anymore)
• Psbt.json_serialize()
• SignOptions
• TxBuilder.add_data()

[jurvis]

hi @thunderbiscuit, we still need Transaction – input() and output() and conversely from 1, the TxIn type.

does .finalize_psbt not require SignOptions as a parameter anymore?

[thunderbiscuit]

We didn't have the Wallet.finalize_psbt() method before (or at least I can't find it anywhere), but you might be referring to the Wallet.sign() method? The sign() method still takes a SignOptions parameter in Rust, but for the bindings we simply pass the default version of that (and have removed it as a parameter). Did you use it to customize the signer options? I'm happy to try to add it back for you next week if you'd like and need it.

[andreasgriffin]

get_height (the current blockchain tip) is missing. It also seems to have vanished from the esplora and electrum client. This is however very useful.

[andreasgriffin]

The RPC client would be great!

[reez]

Note: Have a user on Discord that might need SignOptions back, just making a note of it here and I'll follow up with more information about their specific use case and if that satisfies what they might need.