Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use path parameter for channel name #39

Closed
bluebrown opened this issue Jan 31, 2024 · 1 comment · Fixed by #40
Closed

use path parameter for channel name #39

bluebrown opened this issue Jan 31, 2024 · 1 comment · Fixed by #40
Labels
triage requires review

Comments

@bluebrown
Copy link
Owner

No description provided.

@github-actions github-actions bot added the triage requires review label Jan 31, 2024
@Archisman-Mridha
Copy link
Contributor

Issue description

Currently webhook events are received at /events and the channel name is present as a query parameter in the URL.

Query parameters are generally used for optional parameters. So, we want to switch to path parameters.

Webhook events should be received at /events/<channel-name>.So, the channel name will be present as path parameter instead.

Note

The query parameter option will still be available for backwards compatibility, but it'll be marked as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage requires review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants