Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows binarie is reporting virus by windows defender #4012

Open
drigoskalwalker opened this issue Dec 4, 2024 · 3 comments
Open

Windows binarie is reporting virus by windows defender #4012

drigoskalwalker opened this issue Dec 4, 2024 · 3 comments
Labels
enhancement New feature or request general

Comments

@drigoskalwalker
Copy link

Which version are you using?

1.10.0

Which operating system are you using?

Windows amd64 standard

Describe how to replicate the issue

  1. start the server
  2. publish with ...
  3. read with ...

Server logs

Here is the virus reported: Trojan:Script/Wacatac.B!ml, it didn't happen in the old versions

Network dump

No response

@aler9 aler9 added enhancement New feature or request general labels Dec 4, 2024
@aler9
Copy link
Member

aler9 commented Dec 4, 2024

Hello,
Let's start from a point: binaries present in the Release section do not contain any virus. They are not build or uploaded by humans but entirely produced by the GitHub Actions release pipeline, that exclusively uses open source code contained in this repository. There's (in theory) no way of external interference.

Furthermore, i compared hashes of binaries produced by the pipeline with hashes of binaries present in the Release section, and they correspond.

Now, the actual issue: sometimes the Windows binary gets recognized as a virus by Windows Defender. This has already happened in the past.

A way that is 100% guaranteed to solve the issue consists into signing Windows binaries with certificates released from a Certificate Authority. The lowest price is 250$ / year. This project actually does not have any income and does not need it since there are no direct infrastructure or development expenses. We cannot do it.

A middle way consists into signing binaries with a public certificate. This won't guarantee that executables will be recognized as virus-free, but will allow users to check whether there's some interference between the open source CD pipeline and their local copy of the binary. This can be implemented.

@aler9
Copy link
Member

aler9 commented Jan 1, 2025

Thanks to #4095, checksums of binaries are now computed and shown in the release page. This is the first step for improving the security of binaries and ensuring no one is interfering with the release process.

Next steps will involve the introduction of signing through GPG, Windows-specific signing through certificates and macOS-specific signing.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

This issue is mentioned in release v1.11.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request general
Projects
None yet
Development

No branches or pull requests

2 participants