[TOB-BOB-1] withdrawDepositsToL1 is lacking a pausable modifier

[technovision99]

withdrawDepositsToL1 is lacking a pausable modifier

Severity: Informational
Difficulty:High
Type: Data Validation
Target: src/FusionLock.sol

Description

The FusionLock contract is designed to be pausable, with the documentation saying that all user functionalities can be paused by the owner. However, the withdrawDepositsToL1 function does not have the whenNotPaused modifier. As a result, L1 withdrawals cannot be paused.

fusion-lock/src/FusionLock.sol

Lines 222 to 226 in 0e606d2

	/**
	* @dev Function to withdraw all deposits to Layer 1 for multiple tokens.
	* @param tokens Array of token addresses to withdraw.
	*/
	function withdrawDepositsToL1(address[] memory tokens) external {

Recommendations

Short term, add the whenNotPaused modifier to the function.

Long term, improve unit testing to uncover edge cases and ensure intended behavior throughout the system.