-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert build/publish preview actions to reusable workflow #700
Labels
Comments
benjaminParisel
pushed a commit
that referenced
this issue
May 22, 2024
benjaminParisel
added a commit
to bonitasoft/bonita-doc
that referenced
this issue
Jun 12, 2024
Use the reusable workflow defined in bonita-documentation-site to configure and maintain them more easily. Covers bonitasoft/bonita-documentation-site#686 Covers bonitasoft/bonita-documentation-site#700
This was referenced Aug 7, 2024
benjaminParisel
pushed a commit
to bonitasoft/bonita-central-doc
that referenced
this issue
Aug 7, 2024
Use the reusable workflow defined in bonita-documentation-site to configure and maintain them more easily. Covers bonitasoft/bonita-documentation-site#686 Covers bonitasoft/bonita-documentation-site#700
benjaminParisel
pushed a commit
to bonitasoft/bonita-test-toolkit-doc
that referenced
this issue
Aug 7, 2024
Use the reusable workflow defined in bonita-documentation-site to configure and maintain them more easily. Covers bonitasoft/bonita-documentation-site#686 Covers bonitasoft/bonita-documentation-site#700
benjaminParisel
pushed a commit
to bonitasoft/bonita-continuous-delivery-doc
that referenced
this issue
Aug 7, 2024
Use the reusable workflow defined in bonita-documentation-site to configure and maintain them more easily. Covers bonitasoft/bonita-documentation-site#686 Covers bonitasoft/bonita-documentation-site#700
benjaminParisel
pushed a commit
to bonitasoft/bonita-cloud-doc
that referenced
this issue
Aug 7, 2024
Use the reusable workflow defined in bonita-documentation-site to configure and maintain them more easily. Covers bonitasoft/bonita-documentation-site#686 Covers bonitasoft/bonita-documentation-site#700
tbouffard
moved this from In Progress
to In Review
in Bonita documentation site - work in progress
Aug 7, 2024
github-project-automation
bot
moved this from In Review
to Done
in Bonita documentation site - work in progress
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we use "composite actions, they produce hard to read logs and when used in documentation content repo, they are the sole step of the workflow.
When we created them, the concept of "reusable workflow" didn't exist, that's why we choose this "composite action" implementation.
"Reusable workflow" are more convenient, so we could switch from action to reusable workflow.
Notice that in, the
build-pr-site
action that does the references validation, thefail-on-warning
input default value should betrue
as we always want to fail on validation error. The current default is set to false, it was set to this value to be able to have a smooth transition in all repo during the introduction of Antora Atlas. The transition is now over, so we can change the default value.bonita-documentation-site/.github/actions/build-pr-site/action.yml
Line 17 in ad588f0
The
build-pr-site
action could be replaced by a reusable workflow as well.Tasks
fail-on-warning
input default value should betrue
. ci: introduce reusable workflow to validate references in PR preview #714build-pr-site
action once the new reusable workflow is used everywhere --> ci: move internal actions to reusable workflows #760build-and-publish-pr-preview
action. Require Provide a live preview for contributions done from fork repo #686 to be used in all content repositories --> ci: move internal actions to reusable workflows #760upload-pr-built-site-artifact
action. Require Provide a live preview for contributions done from fork repo #686 and the new reusable workflow to be used in all content repositories --> ci: move internal actions to reusable workflows #760The text was updated successfully, but these errors were encountered: