Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg2: repo-create: --make-parent-dirs does not make parent directories #8619

Open
KenKundert opened this issue Jan 3, 2025 · 3 comments
Open
Milestone

Comments

@KenKundert
Copy link
Contributor

In borg 2.0.0b14 the following command terminates with an error:

borg repo-create -r ~/aaa/bbb/ccc -e none --make-parent-dirs

The error is reported as: posixfs storage base path's parent directory does not exist: /home/ken/aaa/bbb/ccc

With the --make-parent-dirs option I would expect Borg to create the needed directories.

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Jan 3, 2025

Oh, guess I forgot to remove that option from borg.

All the storage stuff is now done by borgstore and that does not offer that (yet?).

It's also somehow questionable whether that should be offered. Creating random directories via a typo is quite easy with that and sometimes one does not have permissions to create the dirs.

@ThomasWaldmann ThomasWaldmann added this to the 2.0.0b15 milestone Jan 3, 2025
@KenKundert
Copy link
Contributor Author

I would hate to see this feature removed. I guess it is possible that a user could mis-type the path and end up with undesired directories, but that is equally true with the alternatives as well. I also don't understand about the concern over the permissions. If they don't have the permissions they will not be able to create the repository with or without the --make-parent-dirs. However there are cloud file servers that people use to hold their repositories, and those services provide very limited or no shell access. There may be no other way to create the directory to hold the repository than by having borg do it with --make-parent-dirs. I'm thinking of rsync and borgbase.

@ThomasWaldmann
Copy link
Member

Yeah, the "limited/no access" servers are a valid use case. I will see what can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants