You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From a quick look, it seems most places are using it in the sense of the comment (that is, checking if there's a boundary, and if so, use one-sided differences), so I suspect that they wouldn't handle periodic X correctly/very well
The documentation of
Mesh::firstX()
sounds like it would return always false for x-periodic grids, but it does not:https://github.com/boutproject/BOUT-dev/blob/master/src/mesh/impls/bout/boutmesh.hxx#L69
https://github.com/boutproject/BOUT-dev/blob/master/src/mesh/impls/bout/boutmesh.cxx#L1488
Is that intentional? Should I fix the comment?
The text was updated successfully, but these errors were encountered: